2022-06-23 11:16:14

by Jiang Jian

[permalink] [raw]
Subject: [PATCH] mlxsw: drop unexpected word 'for' in comments

there is an unexpected word 'for' in the comments that need to be dropped

file - drivers/net/ethernet/mellanox/mlxsw/spectrum2_kvdl.c
line - 18

* ids for for this purpose in partition definition.
changed to:

* ids for this purpose in partition definition.

Signed-off-by: Jiang Jian <[email protected]>
---
drivers/net/ethernet/mellanox/mlxsw/spectrum2_kvdl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum2_kvdl.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum2_kvdl.c
index 10ae1115de6c..24ff305a2995 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum2_kvdl.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum2_kvdl.c
@@ -15,7 +15,7 @@ struct mlxsw_sp2_kvdl_part_info {
* usage bits we need and how many indexes there are
* represented by a single bit. This could be got from FW
* querying appropriate resources. So have the resource
- * ids for for this purpose in partition definition.
+ * ids for this purpose in partition definition.
*/
enum mlxsw_res_id usage_bit_count_res_id;
enum mlxsw_res_id index_range_res_id;
--
2.17.1


2022-06-23 11:55:49

by Ido Schimmel

[permalink] [raw]
Subject: Re: [PATCH] mlxsw: drop unexpected word 'for' in comments

On Thu, Jun 23, 2022 at 06:46:01PM +0800, Jiang Jian wrote:
> there is an unexpected word 'for' in the comments that need to be dropped
>
> file - drivers/net/ethernet/mellanox/mlxsw/spectrum2_kvdl.c
> line - 18
>
> * ids for for this purpose in partition definition.
> changed to:
>
> * ids for this purpose in partition definition.
>
> Signed-off-by: Jiang Jian <[email protected]>

For for net-next:

Reviewed-by: Ido Schimmel <[email protected]>

:)

2022-06-23 16:31:52

by Jakub Kicinski

[permalink] [raw]
Subject: Re: [PATCH] mlxsw: drop unexpected word 'for' in comments

On Thu, 23 Jun 2022 18:46:01 +0800 Jiang Jian wrote:
> file - drivers/net/ethernet/mellanox/mlxsw/spectrum2_kvdl.c
> line - 18
>
> * ids for for this purpose in partition definition.
> changed to:
>
> * ids for this purpose in partition definition.

Please stop putting the change into the description.
I think I already complained about this.
This is exactly the same information as is in the patch itself.

And as other people have pointed out - please say that the word
is repeated not "unexpected".

IDK why you made those changes because your patches on Wednesday
where better:

[PATCH] bnxt: Fix typo in comments

Remove the repeated word 'and' from comments

Signed-off-by: Jiang Jian <[email protected]>

https://lore.kernel.org/r/[email protected]/

I'm dropping these patches from you, please redo them:

https://patchwork.kernel.org/project/netdevbpf/patch/[email protected]/
https://patchwork.kernel.org/project/netdevbpf/patch/[email protected]/
https://patchwork.kernel.org/project/netdevbpf/patch/[email protected]/