2022-05-23 06:01:33

by Nicolas Dichtel

Subject: Re: [PATCH ipsec-next] xfrm: no need to set DST_NOPOLICY in IPv4

Le 20/05/2022 à 12:48, Eyal Birger a écrit :
> This is a cleanup patch following commit e6175a2ed1f1
> ("xfrm: fix "disable_policy" flag use when arriving from different devices")
> which made DST_NOPOLICY no longer be used for inbound policy checks.
>
> On outbound the flag was set, but never used.
>
> As such, avoid setting it altogether and remove the nopolicy argument
> from rt_dst_alloc().
>
> Signed-off-by: Eyal Birger <[email protected]>
Reviewed-by: Nicolas Dichtel <[email protected]>

2022-06-23 11:11:24

by Steffen Klassert

Subject: Re: [PATCH ipsec-next] xfrm: no need to set DST_NOPOLICY in IPv4

On Fri, May 20, 2022 at 02:01:19PM +0200, Nicolas Dichtel wrote:
>
> Le 20/05/2022 ? 12:48, Eyal Birger a ?crit?:
> > This is a cleanup patch following commit e6175a2ed1f1
> > ("xfrm: fix "disable_policy" flag use when arriving from different devices")
> > which made DST_NOPOLICY no longer be used for inbound policy checks.
> >
> > On outbound the flag was set, but never used.
> >
> > As such, avoid setting it altogether and remove the nopolicy argument
> > from rt_dst_alloc().
> >
> > Signed-off-by: Eyal Birger <[email protected]>
> Reviewed-by: Nicolas Dichtel <[email protected]>

Now applied to ipsec-next, thanks everyone!