2022-06-24 02:14:26

by Deming Wang

Subject: [PATCH] media: docs: Modify the section of User xattr

Delete duplicate words of "the".

Signed-off-by: Deming Wang <[email protected]>
---
Documentation/filesystems/overlayfs.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/filesystems/overlayfs.rst b/Documentation/filesystems/overlayfs.rst
index 7da6c30ed596..4c76fda07645 100644
--- a/Documentation/filesystems/overlayfs.rst
+++ b/Documentation/filesystems/overlayfs.rst
@@ -607,7 +607,7 @@ can be removed.
User xattr
----------

-The the "-o userxattr" mount option forces overlayfs to use the
+The "-o userxattr" mount option forces overlayfs to use the
"user.overlay." xattr namespace instead of "trusted.overlay.". This is
useful for unprivileged mounting of overlayfs.

--
2.27.0

2022-06-24 19:47:47

by Jonathan Corbet

Subject: Re: [PATCH] media: docs: Modify the section of User xattr

Deming Wang <[email protected]> writes:

> Delete duplicate words of "the".
>
> Signed-off-by: Deming Wang <[email protected]>
> ---
> Documentation/filesystems/overlayfs.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/filesystems/overlayfs.rst b/Documentation/filesystems/overlayfs.rst
> index 7da6c30ed596..4c76fda07645 100644
> --- a/Documentation/filesystems/overlayfs.rst
> +++ b/Documentation/filesystems/overlayfs.rst
> @@ -607,7 +607,7 @@ can be removed.
> User xattr
> ----------
>
> -The the "-o userxattr" mount option forces overlayfs to use the
> +The "-o userxattr" mount option forces overlayfs to use the
> "user.overlay." xattr namespace instead of "trusted.overlay.". This is
> useful for unprivileged mounting of overlayfs.

I've applied this but changed the patch title. This is not a media
patch, and "modify" tells the reader nothing; it's now "docs: Remove
duplicate word".

Thanks,

jon

2022-06-25 01:17:33

by Bagas Sanjaya

Subject: Re: [PATCH] media: docs: Modify the section of User xattr

On 6/24/22 08:46, Deming Wang wrote:
> Delete duplicate words of "the".
>

I think "Modify something" isn't clear subject, because reviewers
don't know at glance the logical change this patch is doing other
than actually reading the diff below.

For the patch message, what about "Remove duplicate the"?

In this case of trivial patch, it's OK to have the patch message
same as the subject, if the message can't be described more
concise but clearer.

> @@ -607,7 +607,7 @@ can be removed.
> User xattr
> ----------
>
> -The the "-o userxattr" mount option forces overlayfs to use the
> +The "-o userxattr" mount option forces overlayfs to use the
> "user.overlay." xattr namespace instead of "trusted.overlay.". This is
> useful for unprivileged mounting of overlayfs.
>

The diff looks OK.

Thanks.

--
An old man doll... just what I always wanted! - Clara