2022-06-24 07:43:55

by Jiapeng Chong

Subject: [PATCH] usb: musb: Fix missing error code in mpfs_probe()

The error code is missing in this code scenario, add the error code
'-ENOMEM' to the return value 'ret'.

This was found by coccicheck:

drivers/usb/musb/mpfs.c:185 mpfs_probe() warn: missing error code 'ret'.

Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/usb/musb/mpfs.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/musb/mpfs.c b/drivers/usb/musb/mpfs.c
index 99666ef8af06..c8bf6570bcc4 100644
--- a/drivers/usb/musb/mpfs.c
+++ b/drivers/usb/musb/mpfs.c
@@ -181,8 +181,10 @@ static int mpfs_probe(struct platform_device *pdev)
glue->clk = clk;

pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL);
- if (!pdata)
+ if (!pdata) {
+ ret = -ENOMEM;
goto err_clk_disable;
+ }

pdata->config = &mpfs_musb_hdrc_config;
pdata->platform_ops = &mpfs_ops;
--
2.20.1.7.g153144c

2022-06-24 12:03:17

by Greg Kroah-Hartman

Subject: Re: [PATCH] usb: musb: Fix missing error code in mpfs_probe()

On Fri, Jun 24, 2022 at 03:25:15PM +0800, Jiapeng Chong wrote:
> The error code is missing in this code scenario, add the error code
> '-ENOMEM' to the return value 'ret'.
>
> This was found by coccicheck:
>
> drivers/usb/musb/mpfs.c:185 mpfs_probe() warn: missing error code 'ret'.
>
> Signed-off-by: Jiapeng Chong <[email protected]>
> ---
> drivers/usb/musb/mpfs.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/musb/mpfs.c b/drivers/usb/musb/mpfs.c
> index 99666ef8af06..c8bf6570bcc4 100644
> --- a/drivers/usb/musb/mpfs.c
> +++ b/drivers/usb/musb/mpfs.c
> @@ -181,8 +181,10 @@ static int mpfs_probe(struct platform_device *pdev)
> glue->clk = clk;
>
> pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL);
> - if (!pdata)
> + if (!pdata) {
> + ret = -ENOMEM;
> goto err_clk_disable;
> + }
>
> pdata->config = &mpfs_musb_hdrc_config;
> pdata->platform_ops = &mpfs_ops;
> --
> 2.20.1.7.g153144c
>

Dan beat you to it, and provided a better fix:
https://lore.kernel.org/r/YrVmLEc/FOEzNdzj@kili

thanks,

greg k-h