2022-06-25 02:03:00

by Souptick Joarder

Subject: [PATCH] drm/amd/display: Removed unused variable ret

From: "Souptick Joarder (HPE)" <[email protected]>

Kernel test robot throws below warning ->

drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link.c:
In function 'dc_link_reduce_mst_payload':
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link.c:3782:32:
warning: variable 'ret' set but not used [-Wunused-but-set-variable]
3782 | enum act_return_status ret;

Removed the unused ret variable.

Reported-by: kernel test robot <[email protected]>
Signed-off-by: Souptick Joarder (HPE) <[email protected]>
---
drivers/gpu/drm/amd/display/dc/core/dc_link.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
index 55a8f58ee239..445357623d8b 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
@@ -3706,7 +3706,6 @@ enum dc_status dc_link_reduce_mst_payload(struct pipe_ctx *pipe_ctx, uint32_t bw
struct fixed31_32 pbn_per_slot;
struct dp_mst_stream_allocation_table proposed_table = {0};
uint8_t i;
- enum act_return_status ret;
const struct link_hwss *link_hwss = get_link_hwss(link, &pipe_ctx->link_res);
DC_LOGGER_INIT(link->ctx->logger);

@@ -3777,7 +3776,7 @@ enum dc_status dc_link_reduce_mst_payload(struct pipe_ctx *pipe_ctx, uint32_t bw
&link->mst_stream_alloc_table);

/* poll for immediate branch device ACT handled */
- ret = dm_helpers_dp_mst_poll_for_allocation_change_trigger(
+ dm_helpers_dp_mst_poll_for_allocation_change_trigger(
stream->ctx,
stream);

--
2.25.1

2022-06-27 22:30:06

by Alex Deucher

Subject: Re: [PATCH] drm/amd/display: Removed unused variable ret

Applied. Thanks!

Alex

On Fri, Jun 24, 2022 at 9:42 PM Souptick Joarder <[email protected]> wrote:
>
> From: "Souptick Joarder (HPE)" <[email protected]>
>
> Kernel test robot throws below warning ->
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link.c:
> In function 'dc_link_reduce_mst_payload':
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link.c:3782:32:
> warning: variable 'ret' set but not used [-Wunused-but-set-variable]
> 3782 | enum act_return_status ret;
>
> Removed the unused ret variable.
>
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Souptick Joarder (HPE) <[email protected]>
> ---
> drivers/gpu/drm/amd/display/dc/core/dc_link.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> index 55a8f58ee239..445357623d8b 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> @@ -3706,7 +3706,6 @@ enum dc_status dc_link_reduce_mst_payload(struct pipe_ctx *pipe_ctx, uint32_t bw
> struct fixed31_32 pbn_per_slot;
> struct dp_mst_stream_allocation_table proposed_table = {0};
> uint8_t i;
> - enum act_return_status ret;
> const struct link_hwss *link_hwss = get_link_hwss(link, &pipe_ctx->link_res);
> DC_LOGGER_INIT(link->ctx->logger);
>
> @@ -3777,7 +3776,7 @@ enum dc_status dc_link_reduce_mst_payload(struct pipe_ctx *pipe_ctx, uint32_t bw
> &link->mst_stream_alloc_table);
>
> /* poll for immediate branch device ACT handled */
> - ret = dm_helpers_dp_mst_poll_for_allocation_change_trigger(
> + dm_helpers_dp_mst_poll_for_allocation_change_trigger(
> stream->ctx,
> stream);
>
> --
> 2.25.1
>