The lp50xx LEDs expects to have single-color LED children with unit
addresses. This is required by the driver and provided by existing
DTSes. Fix the binding to match actual usage.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
Fixes: dce1452301e7 ("dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers")
---
Documentation/devicetree/bindings/leds/leds-lp50xx.yaml | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml b/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
index f12fe5b53f30..c274a10bbde6 100644
--- a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
+++ b/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
@@ -65,8 +65,14 @@ patternProperties:
for the child node. The LED modules can either be used stand alone
or grouped into a module bank.
+ '#address-cells':
+ const: 1
+
+ '#size-cells':
+ const: 0
+
patternProperties:
- "(^led-[0-9a-f]$|led)":
+ "^led@[0-9a-f]+$":
type: object
$ref: common.yaml#
--
2.34.1
On Fri, 24 Jun 2022 13:13:25 +0200, Krzysztof Kozlowski wrote:
> The lp50xx LEDs expects to have single-color LED children with unit
> addresses. This is required by the driver and provided by existing
> DTSes. Fix the binding to match actual usage.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> Fixes: dce1452301e7 ("dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers")
> ---
> Documentation/devicetree/bindings/leds/leds-lp50xx.yaml | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/leds/leds-lp50xx.example.dtb: led-controller@14: multi-led@2:#size-cells:0:0: 0 was expected
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
On 24/06/2022 19:26, Rob Herring wrote:
> On Fri, 24 Jun 2022 13:13:25 +0200, Krzysztof Kozlowski wrote:
>> The lp50xx LEDs expects to have single-color LED children with unit
>> addresses. This is required by the driver and provided by existing
>> DTSes. Fix the binding to match actual usage.
>>
>> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>> Fixes: dce1452301e7 ("dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers")
>> ---
>> Documentation/devicetree/bindings/leds/leds-lp50xx.yaml | 8 +++++++-
>> 1 file changed, 7 insertions(+), 1 deletion(-)
>>
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/leds/leds-lp50xx.example.dtb: led-controller@14: multi-led@2:#size-cells:0:0: 0 was expected
> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
>
This is expected and fixed in:
https://lore.kernel.org/all/[email protected]/
I did not combine this patch with above patchset because this one is a
fix and might be backported to stable.
Best regards,
Krzysztof
On Fri, 24 Jun 2022 13:13:25 +0200, Krzysztof Kozlowski wrote:
> The lp50xx LEDs expects to have single-color LED children with unit
> addresses. This is required by the driver and provided by existing
> DTSes. Fix the binding to match actual usage.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> Fixes: dce1452301e7 ("dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers")
> ---
> Documentation/devicetree/bindings/leds/leds-lp50xx.yaml | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
Reviewed-by: Rob Herring <[email protected]>
On 24/06/2022 19:31, Krzysztof Kozlowski wrote:
> On 24/06/2022 19:26, Rob Herring wrote:
>> On Fri, 24 Jun 2022 13:13:25 +0200, Krzysztof Kozlowski wrote:
>>> The lp50xx LEDs expects to have single-color LED children with unit
>>> addresses. This is required by the driver and provided by existing
>>> DTSes. Fix the binding to match actual usage.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>>> Fixes: dce1452301e7 ("dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers")
>>> ---
>>> Documentation/devicetree/bindings/leds/leds-lp50xx.yaml | 8 +++++++-
>>> 1 file changed, 7 insertions(+), 1 deletion(-)
>>>
>>
>> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
>> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>>
>> yamllint warnings/errors:
>>
>> dtschema/dtc warnings/errors:
>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/leds/leds-lp50xx.example.dtb: led-controller@14: multi-led@2:#size-cells:0:0: 0 was expected
>> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
>>
>
> This is expected and fixed in:
> https://lore.kernel.org/all/[email protected]/
>
> I did not combine this patch with above patchset because this one is a
> fix and might be backported to stable.
>
Anyone willing to pick this up? This is a fix.
Best regards,
Krzysztof
On Fri 2022-06-24 13:13:25, Krzysztof Kozlowski wrote:
> The lp50xx LEDs expects to have single-color LED children with unit
> addresses. This is required by the driver and provided by existing
> DTSes. Fix the binding to match actual usage.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> Fixes: dce1452301e7 ("dt: bindings: lp50xx: Introduce the lp50xx
family of RGB drivers")
Thanks, applied - w/o the fixes tag.
Best regards,
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.
On Fri, Jun 24, 2022 at 5:13 AM Krzysztof Kozlowski
<[email protected]> wrote:
>
> The lp50xx LEDs expects to have single-color LED children with unit
> addresses. This is required by the driver and provided by existing
> DTSes. Fix the binding to match actual usage.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> Fixes: dce1452301e7 ("dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers")
> ---
> Documentation/devicetree/bindings/leds/leds-lp50xx.yaml | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml b/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
> index f12fe5b53f30..c274a10bbde6 100644
> --- a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
> +++ b/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
> @@ -65,8 +65,14 @@ patternProperties:
> for the child node. The LED modules can either be used stand alone
> or grouped into a module bank.
>
> + '#address-cells':
> + const: 1
> +
> + '#size-cells':
> + const: 0
> +
> patternProperties:
> - "(^led-[0-9a-f]$|led)":
> + "^led@[0-9a-f]+$":
Looks like you forgot to update the example. Now failing with
'unevaluatedProperties' fixed:
/builds/robherring/linux-dt/Documentation/devicetree/bindings/leds/leds-lp50xx.example.dtb:
led-controller@14: multi-led@1: Unevaluated properties are not allowed
('led-0', 'led-1', 'led-2' were unexpected)
From schema: /builds/robherring/linux-dt/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
/builds/robherring/linux-dt/Documentation/devicetree/bindings/leds/leds-lp50xx.example.dtb:
led-controller@14: multi-led@2: Unevaluated properties are not allowed
('#size-cells', 'led-6', 'led-7', 'led-8' were unexpected)
From schema: /builds/robherring/linux-dt/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
/builds/robherring/linux-dt/Documentation/devicetree/bindings/leds/leds-lp50xx.example.dtb:
led-controller@14: multi-led@2:#size-cells:0:0: 0 was expected
From schema: /builds/robherring/linux-dt/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
Rob
On 18/07/2022 17:18, Rob Herring wrote:
> On Fri, Jun 24, 2022 at 5:13 AM Krzysztof Kozlowski
> <[email protected]> wrote:
>>
>> The lp50xx LEDs expects to have single-color LED children with unit
>> addresses. This is required by the driver and provided by existing
>> DTSes. Fix the binding to match actual usage.
>>
>> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>> Fixes: dce1452301e7 ("dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers")
>> ---
>> Documentation/devicetree/bindings/leds/leds-lp50xx.yaml | 8 +++++++-
>> 1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml b/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
>> index f12fe5b53f30..c274a10bbde6 100644
>> --- a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
>> +++ b/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
>> @@ -65,8 +65,14 @@ patternProperties:
>> for the child node. The LED modules can either be used stand alone
>> or grouped into a module bank.
>>
>> + '#address-cells':
>> + const: 1
>> +
>> + '#size-cells':
>> + const: 0
>> +
>> patternProperties:
>> - "(^led-[0-9a-f]$|led)":
>> + "^led@[0-9a-f]+$":
>
> Looks like you forgot to update the example. Now failing with
> 'unevaluatedProperties' fixed:
Yeah, this was fixed in my other patch:
https://lore.kernel.org/all/[email protected]/
and I assumed Pavel will also pick it up... It has been waiting for more
than one month.
Best regards,
Krzysztof