2022-06-28 08:46:31

by Felix Schlepper

Subject: [PATCH 3/7] Staging: rtl8192e: Avoid multiple assignments

This addresses an issue raised by checkpatch.pl:

$ ./scripts/checkpatch.pl --terse -f drivers/staging/rtl8192e/rtllib_wx.c
CHECK: multiple assignments should be avoided

This patch does not change the logical of the assignments.

Signed-off-by: Felix Schlepper <[email protected]>
---
drivers/staging/rtl8192e/rtllib_wx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8192e/rtllib_wx.c b/drivers/staging/rtl8192e/rtllib_wx.c
index 7bd1e829ff7e..c8fc66113b41 100644
--- a/drivers/staging/rtl8192e/rtllib_wx.c
+++ b/drivers/staging/rtl8192e/rtllib_wx.c
@@ -160,7 +160,8 @@ static inline char *rtl819x_translate_scan(struct rtllib_device *ieee,
max_rate = rate;
}
iwe.cmd = SIOCGIWRATE;
- iwe.u.bitrate.fixed = iwe.u.bitrate.disabled = 0;
+ iwe.u.bitrate.disabled = 0;
+ iwe.u.bitrate.fixed = iwe.u.bitrate.disabled;
iwe.u.bitrate.value = max_rate * 500000;
start = iwe_stream_add_event_rsl(info, start, stop, &iwe, IW_EV_PARAM_LEN);
iwe.cmd = IWEVCUSTOM;
--
2.36.1

2022-06-29 16:46:14

by Dan Carpenter

Subject: Re: [PATCH 3/7] Staging: rtl8192e: Avoid multiple assignments

On Tue, Jun 28, 2022 at 10:30:52AM +0200, Felix Schlepper wrote:
> This addresses an issue raised by checkpatch.pl:
>
> $ ./scripts/checkpatch.pl --terse -f drivers/staging/rtl8192e/rtllib_wx.c
> CHECK: multiple assignments should be avoided
>
> This patch does not change the logical of the assignments.
>
> Signed-off-by: Felix Schlepper <[email protected]>
> ---
> drivers/staging/rtl8192e/rtllib_wx.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192e/rtllib_wx.c b/drivers/staging/rtl8192e/rtllib_wx.c
> index 7bd1e829ff7e..c8fc66113b41 100644
> --- a/drivers/staging/rtl8192e/rtllib_wx.c
> +++ b/drivers/staging/rtl8192e/rtllib_wx.c
> @@ -160,7 +160,8 @@ static inline char *rtl819x_translate_scan(struct rtllib_device *ieee,
> max_rate = rate;
> }
> iwe.cmd = SIOCGIWRATE;
> - iwe.u.bitrate.fixed = iwe.u.bitrate.disabled = 0;
> + iwe.u.bitrate.disabled = 0;
> + iwe.u.bitrate.fixed = iwe.u.bitrate.disabled;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
This assignment makes no sense. Why are we setting fixed = disabled?
If you're going to split it apart do:

iwe.u.bitrate.disabled = 0;
iwe.u.bitrate.fixed = 0;

regards,
dan carpenter