2022-07-04 11:27:53

by kunyu

Subject: [PATCH] fs/ntfs3/indx: Remove unnecessary 'NULL' values from Pointer

Pointer variables allocate memory first, and then judge. There is no
need to initialize the assignment.

Signed-off-by: Li kunyu <[email protected]>
---
fs/ntfs3/index.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/ntfs3/index.c b/fs/ntfs3/index.c
index 6f81e3a49abf..b5c92b6ce01c 100644
--- a/fs/ntfs3/index.c
+++ b/fs/ntfs3/index.c
@@ -1685,8 +1685,8 @@ indx_insert_into_buffer(struct ntfs_index *indx, struct ntfs_inode *ni,
{
int err;
const struct NTFS_DE *sp;
- struct NTFS_DE *e, *de_t, *up_e = NULL;
- struct indx_node *n2 = NULL;
+ struct NTFS_DE *e, *de_t, *up_e;
+ struct indx_node *n2;
struct indx_node *n1 = fnd->nodes[level];
struct INDEX_HDR *hdr1 = &n1->index->ihdr;
struct INDEX_HDR *hdr2;
--
2.18.2

2022-07-06 16:12:10

by Konstantin Komarov

Subject: Re: [PATCH] fs/ntfs3/indx: Remove unnecessary 'NULL' values from Pointer

On 7/4/22 13:31, Li kunyu wrote:
> Pointer variables allocate memory first, and then judge. There is no
> need to initialize the assignment.
>
> Signed-off-by: Li kunyu <[email protected]>
> ---
> fs/ntfs3/index.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ntfs3/index.c b/fs/ntfs3/index.c
> index 6f81e3a49abf..b5c92b6ce01c 100644
> --- a/fs/ntfs3/index.c
> +++ b/fs/ntfs3/index.c
> @@ -1685,8 +1685,8 @@ indx_insert_into_buffer(struct ntfs_index *indx, struct ntfs_inode *ni,
> {
> int err;
> const struct NTFS_DE *sp;
> - struct NTFS_DE *e, *de_t, *up_e = NULL;
> - struct indx_node *n2 = NULL;
> + struct NTFS_DE *e, *de_t, *up_e;
> + struct indx_node *n2;
> struct indx_node *n1 = fnd->nodes[level];
> struct INDEX_HDR *hdr1 = &n1->index->ihdr;
> struct INDEX_HDR *hdr2;

Thanks for patch, applied!