2022-07-04 13:25:49

by Yuan Can

Subject: [PATCH -next] gpio: pxa: Add missing clk_disable_unprepare() in pxa_gpio_probe()

Add clk_disable_unprepare() on error path in pxa_gpio_probe().

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Yuan Can <[email protected]>
---
drivers/gpio/gpio-pxa.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c
index c7fbfa3ae43b..08963975dd1b 100644
--- a/drivers/gpio/gpio-pxa.c
+++ b/drivers/gpio/gpio-pxa.c
@@ -676,6 +676,7 @@ static int pxa_gpio_probe(struct platform_device *pdev)
/* Initialize GPIO chips */
ret = pxa_init_gpio_chip(pchip, pxa_last_gpio + 1, gpio_reg_base);
if (ret) {
+ clk_disable_unprepare(clk);
clk_put(clk);
return ret;
}
--
2.17.1

2022-07-05 18:29:24

by Bartosz Golaszewski

Subject: Re: [PATCH -next] gpio: pxa: Add missing clk_disable_unprepare() in pxa_gpio_probe()

On Mon, Jul 4, 2022 at 3:05 PM Yuan Can <[email protected]> wrote:
>
> Add clk_disable_unprepare() on error path in pxa_gpio_probe().
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Yuan Can <[email protected]>
> ---
> drivers/gpio/gpio-pxa.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c
> index c7fbfa3ae43b..08963975dd1b 100644
> --- a/drivers/gpio/gpio-pxa.c
> +++ b/drivers/gpio/gpio-pxa.c
> @@ -676,6 +676,7 @@ static int pxa_gpio_probe(struct platform_device *pdev)
> /* Initialize GPIO chips */
> ret = pxa_init_gpio_chip(pchip, pxa_last_gpio + 1, gpio_reg_base);
> if (ret) {
> + clk_disable_unprepare(clk);
> clk_put(clk);
> return ret;
> }
> --
> 2.17.1
>

Hi Yuan!

This patch is not wrong but it's incomplete. A quick glance at the
driver is telling me that once probe succeeded, nobody ever disables
or releases the clock on remove. There's no remove callback and no
devm action set for that. Please take a look at the patch I just sent.

Bart