2022-07-11 14:58:48

by Yassine Oudjana

Subject: [PATCH v2 0/3] media: i2c: ak7375: Add regulator management

From: Yassine Oudjana <[email protected]>

This series adds needed regulator management for the AK7375 VCM.
A DT schema conversion is made before adding new properties.

Changes since v1:
- Add vendor prefix to DT binding doc file name
- Reorganize variable declaration
- Change the power-on delay range to 3000-3500 microseconds.

Yassine Oudjana (3):
media: dt-bindings: ak7375: Convert to DT schema
media: dt-bindings: ak7375: Add supplies
media: i2c: ak7375: Add regulator management

.../devicetree/bindings/media/i2c/ak7375.txt | 8 ---
.../media/i2c/asahi-kasei,ak7375.yaml | 52 +++++++++++++++++++
MAINTAINERS | 2 +-
drivers/media/i2c/ak7375.c | 39 ++++++++++++++
4 files changed, 92 insertions(+), 9 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/media/i2c/ak7375.txt
create mode 100644 Documentation/devicetree/bindings/media/i2c/asahi-kasei,ak7375.yaml

--
2.37.0

2022-07-11 15:22:33

by Yassine Oudjana

Subject: [PATCH v2 2/3] media: dt-bindings: ak7375: Add supplies

From: Yassine Oudjana <[email protected]>

Add supply properties to describe regulators needed to power
the AK7375 VCM.

Signed-off-by: Yassine Oudjana <[email protected]>
Acked-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/media/i2c/asahi-kasei,ak7375.yaml | 11 +++++++++++
1 file changed, 11 insertions(+)

diff --git a/Documentation/devicetree/bindings/media/i2c/asahi-kasei,ak7375.yaml b/Documentation/devicetree/bindings/media/i2c/asahi-kasei,ak7375.yaml
index 22b1251b16ee..22a810fc7222 100644
--- a/Documentation/devicetree/bindings/media/i2c/asahi-kasei,ak7375.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/asahi-kasei,ak7375.yaml
@@ -20,9 +20,17 @@ properties:
reg:
maxItems: 1

+ vdd-supply:
+ description: VDD supply
+
+ vio-supply:
+ description: I/O pull-up supply
+
required:
- compatible
- reg
+ - vdd-supply
+ - vio-supply

additionalProperties: false

@@ -35,6 +43,9 @@ examples:
ak7375: camera-lens@c {
compatible = "asahi-kasei,ak7375";
reg = <0x0c>;
+
+ vdd-supply = <&vreg_l23a_2p8>;
+ vio-supply = <&vreg_lvs1a_1p8>;
};
};

--
2.37.0

2022-11-28 06:57:33

by Umang Jain

Subject: Re: [PATCH v2 2/3] media: dt-bindings: ak7375: Add supplies

Hi Yassine,

I have tested this VCM with IMX519 arducam sensor with a auto-focus
algorithm plumbed with libcamera [1]

On 7/11/22 8:10 PM, Yassine Oudjana wrote:
> From: Yassine Oudjana <[email protected]>
>
> Add supply properties to describe regulators needed to power
> the AK7375 VCM.
>
> Signed-off-by: Yassine Oudjana <[email protected]>
> Acked-by: Krzysztof Kozlowski <[email protected]>

So,

Tested-by: Umang Jain <[email protected]>

[1] https://patchwork.libcamera.org/project/libcamera/list/?series=3174
> ---
> .../bindings/media/i2c/asahi-kasei,ak7375.yaml | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/asahi-kasei,ak7375.yaml b/Documentation/devicetree/bindings/media/i2c/asahi-kasei,ak7375.yaml
> index 22b1251b16ee..22a810fc7222 100644
> --- a/Documentation/devicetree/bindings/media/i2c/asahi-kasei,ak7375.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/asahi-kasei,ak7375.yaml
> @@ -20,9 +20,17 @@ properties:
> reg:
> maxItems: 1
>
> + vdd-supply:
> + description: VDD supply
> +
> + vio-supply:
> + description: I/O pull-up supply
> +
> required:
> - compatible
> - reg
> + - vdd-supply
> + - vio-supply
>
> additionalProperties: false
>
> @@ -35,6 +43,9 @@ examples:
> ak7375: camera-lens@c {
> compatible = "asahi-kasei,ak7375";
> reg = <0x0c>;
> +
> + vdd-supply = <&vreg_l23a_2p8>;
> + vio-supply = <&vreg_lvs1a_1p8>;
> };
> };
>