2022-07-16 17:41:06

by Dario Binacchi

Subject: [RFC PATCH] can: can327: remove useless header inclusions

Include only the necessary headers.

CC: Max Staudt <[email protected]>
Signed-off-by: Dario Binacchi <[email protected]>

---

drivers/net/can/can327.c | 19 -------------------
1 file changed, 19 deletions(-)

diff --git a/drivers/net/can/can327.c b/drivers/net/can/can327.c
index 5da7778d92dc..5b0686f953ed 100644
--- a/drivers/net/can/can327.c
+++ b/drivers/net/can/can327.c
@@ -12,28 +12,9 @@

#define pr_fmt(fmt) "can327: " fmt

-#include <linux/init.h>
#include <linux/module.h>
-
-#include <linux/bitops.h>
-#include <linux/ctype.h>
-#include <linux/errno.h>
-#include <linux/kernel.h>
-#include <linux/list.h>
-#include <linux/lockdep.h>
-#include <linux/netdevice.h>
-#include <linux/skbuff.h>
-#include <linux/spinlock.h>
-#include <linux/string.h>
#include <linux/tty.h>
-#include <linux/tty_ldisc.h>
-#include <linux/workqueue.h>
-
-#include <uapi/linux/tty.h>
-
-#include <linux/can.h>
#include <linux/can/dev.h>
-#include <linux/can/error.h>
#include <linux/can/rx-offload.h>

#define CAN327_NAPI_WEIGHT 4
--
2.32.0

2022-07-17 21:54:49

by Max Staudt

Subject: Re: [RFC PATCH] can: can327: remove useless header inclusions

On Sat, 16 Jul 2022 19:02:01 +0200
Dario Binacchi <[email protected]> wrote:

> -#include <linux/init.h>
> #include <linux/module.h>
> -
> -#include <linux/bitops.h>
> -#include <linux/ctype.h>
> -#include <linux/errno.h>
> -#include <linux/kernel.h>
> -#include <linux/list.h>
> -#include <linux/lockdep.h>
> -#include <linux/netdevice.h>
> -#include <linux/skbuff.h>
> -#include <linux/spinlock.h>
> -#include <linux/string.h>
> #include <linux/tty.h>
> -#include <linux/tty_ldisc.h>
> -#include <linux/workqueue.h>
> -
> -#include <uapi/linux/tty.h>
> -
> -#include <linux/can.h>
> #include <linux/can/dev.h>
> -#include <linux/can/error.h>
> #include <linux/can/rx-offload.h>

AFAIK, the coding style is to not rely on headers including other
headers. Instead, the appropriate header for every symbol used should
be included.

This is also valid for the similar patch you submitted for slcan.


Unless something has changed, this is a NAK from me, sorry.


Max

2022-07-18 07:35:32

by Dario Binacchi

Subject: Re: [RFC PATCH] can: can327: remove useless header inclusions

Hi Max,

On Sun, Jul 17, 2022 at 11:50 PM Max Staudt <[email protected]> wrote:
>
> On Sat, 16 Jul 2022 19:02:01 +0200
> Dario Binacchi <[email protected]> wrote:
>
> > -#include <linux/init.h>
> > #include <linux/module.h>
> > -
> > -#include <linux/bitops.h>
> > -#include <linux/ctype.h>
> > -#include <linux/errno.h>
> > -#include <linux/kernel.h>
> > -#include <linux/list.h>
> > -#include <linux/lockdep.h>
> > -#include <linux/netdevice.h>
> > -#include <linux/skbuff.h>
> > -#include <linux/spinlock.h>
> > -#include <linux/string.h>
> > #include <linux/tty.h>
> > -#include <linux/tty_ldisc.h>
> > -#include <linux/workqueue.h>
> > -
> > -#include <uapi/linux/tty.h>
> > -
> > -#include <linux/can.h>
> > #include <linux/can/dev.h>
> > -#include <linux/can/error.h>
> > #include <linux/can/rx-offload.h>
>
> AFAIK, the coding style is to not rely on headers including other
> headers. Instead, the appropriate header for every symbol used should
> be included.

Thanks for the explanation.

>
> This is also valid for the similar patch you submitted for slcan.

Probably something can be removed (if_arp.h, if_ether.h, ...).
I will take can327.c as a reference.

Thanks and regards,
Dario

>
>
> Unless something has changed, this is a NAK from me, sorry.
>
>
> Max



--

Dario Binacchi

Embedded Linux Developer

[email protected]

__________________________________


Amarula Solutions SRL

Via Le Canevare 30, 31100 Treviso, Veneto, IT

T. +39 042 243 5310
[email protected]

http://www.amarulasolutions.com