2022-07-20 05:40:29

by Steev Klimaszewski

[permalink] [raw]
Subject: [PATCH] drm/panel-edp: add IVO M133NW4J-R3 panel entry

Add an eDP panel entry for IVO M133NW4J-R3.

Due to lack of documentation, use the delay_200_500_e50 timings for now.

Signed-off-by: Steev Klimaszewski <[email protected]>

---
I'm basing my information gathering off what I could find for the IVO
M133NW4J panels on panelook.com. R0 is glossy, and mine is not. R2
says it is discontinued, and I am just guessing that I have the R3 as
the Thinkpad X13s just came out, roughly a month ago.
---
drivers/gpu/drm/panel/panel-edp.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c
index 5024ba690abf..8f89226e9db5 100644
--- a/drivers/gpu/drm/panel/panel-edp.c
+++ b/drivers/gpu/drm/panel/panel-edp.c
@@ -1883,6 +1883,7 @@ static const struct edp_panel_entry edp_panels[] = {

EDP_PANEL_ENTRY('C', 'M', 'N', 0x114c, &innolux_n116bca_ea1.delay, "N116BCA-EA1"),

+ EDP_PANEL_ENTRY('I', 'V', 'O', 0x854b, &delay_200_500_p2e100, "M133NW4J-R2"),
EDP_PANEL_ENTRY('K', 'D', 'B', 0x0624, &kingdisplay_kd116n21_30nv_a010.delay, "116N21-30NV-A010"),
EDP_PANEL_ENTRY('K', 'D', 'B', 0x1120, &delay_200_500_e80_d50, "116N29-30NK-C007"),

--
2.30.2


2022-07-20 06:02:22

by Steev Klimaszewski

[permalink] [raw]
Subject: [PATCH v2] drm/panel-edp: add IVO M133NW4J-R3 panel entry

Add an eDP panel entry for IVO M133NW4J-R3.

Due to lack of documentation, use the delay_200_500_e50 timings for now.

Signed-off-by: Steev Klimaszewski <[email protected]>

---
v2 - actually mark it as R3 in the change, not R2...

I'm basing my information gathering off what I could find for the IVO
M133NW4J panels on panelook.com. R0 is glossy, and mine is not. R2
says it is discontinued, and I am just guessing that I have the R3 as
the Thinkpad X13s just came out, roughly a month ago.

Signed-off-by: Steev Klimaszewski <[email protected]>
---
drivers/gpu/drm/panel/panel-edp.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c
index 5024ba690abf..870b98041c60 100644
--- a/drivers/gpu/drm/panel/panel-edp.c
+++ b/drivers/gpu/drm/panel/panel-edp.c
@@ -1883,6 +1883,7 @@ static const struct edp_panel_entry edp_panels[] = {

EDP_PANEL_ENTRY('C', 'M', 'N', 0x114c, &innolux_n116bca_ea1.delay, "N116BCA-EA1"),

+ EDP_PANEL_ENTRY('I', 'V', 'O', 0x854b, &delay_200_500_p2e100, "M133NW4J-R3"),
EDP_PANEL_ENTRY('K', 'D', 'B', 0x0624, &kingdisplay_kd116n21_30nv_a010.delay, "116N21-30NV-A010"),
EDP_PANEL_ENTRY('K', 'D', 'B', 0x1120, &delay_200_500_e80_d50, "116N29-30NK-C007"),

--
2.30.2

2022-08-23 19:26:58

by Doug Anderson

[permalink] [raw]
Subject: Re: [PATCH v2] drm/panel-edp: add IVO M133NW4J-R3 panel entry

Hi,

On Tue, Jul 19, 2022 at 10:42 PM Steev Klimaszewski <[email protected]> wrote:
>
> Add an eDP panel entry for IVO M133NW4J-R3.
>
> Due to lack of documentation, use the delay_200_500_e50 timings for now.

Doesn't actually match the commit, which uses "delay_200_500_p2e100".
Fixing while applying.


> Signed-off-by: Steev Klimaszewski <[email protected]>
>
> ---
> v2 - actually mark it as R3 in the change, not R2...
>
> I'm basing my information gathering off what I could find for the IVO
> M133NW4J panels on panelook.com. R0 is glossy, and mine is not. R2
> says it is discontinued, and I am just guessing that I have the R3 as
> the Thinkpad X13s just came out, roughly a month ago.
>
> Signed-off-by: Steev Klimaszewski <[email protected]>
> ---
> drivers/gpu/drm/panel/panel-edp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c
> index 5024ba690abf..870b98041c60 100644
> --- a/drivers/gpu/drm/panel/panel-edp.c
> +++ b/drivers/gpu/drm/panel/panel-edp.c
> @@ -1883,6 +1883,7 @@ static const struct edp_panel_entry edp_panels[] = {
>
> EDP_PANEL_ENTRY('C', 'M', 'N', 0x114c, &innolux_n116bca_ea1.delay, "N116BCA-EA1"),
>
> + EDP_PANEL_ENTRY('I', 'V', 'O', 0x854b, &delay_200_500_p2e100, "M133NW4J-R3"),

I resolved the merge conflict and applied. Pushed to drm-misc-next:

0f9fa5f58c78 drm/panel-edp: add IVO M133NW4J-R3 panel entry

-Doug