Hi all,
After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c: In function 'DISPCLKDPPCLKDCFCLKDeepSleepPrefetchParametersWatermarksAndPerformanceCalculation':
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c:1659:1: error: the frame size of 2144 bytes is larger than 2048 bytes [-Werror=frame-larger-than=]
1659 | }
| ^
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c: In function 'dml32_ModeSupportAndSystemConfigurationFull':
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c:3799:1: error: the frame size of 2464 bytes is larger than 2048 bytes [-Werror=frame-larger-than=]
3799 | } // ModeSupportAndSystemConfigurationFull
| ^
cc1: all warnings being treated as errors
I can't see anything obvious that caused this. The second one was
previously fixed by commit
01cf387b1c7f ("drm/amdgpu/display: reduce stack size in dml32_ModeSupportAndSystemConfigurationFull()")
Usinf the amdgpu tree from next-20220718 fixes the problem, so I have
done that for today.
--
Cheers,
Stephen Rothwell
Hi all,
On Tue, 19 Jul 2022 12:36:07 +1000 Stephen Rothwell <[email protected]> wrote:
>
> After merging the amdgpu tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c: In function 'DISPCLKDPPCLKDCFCLKDeepSleepPrefetchParametersWatermarksAndPerformanceCalculation':
> drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c:1659:1: error: the frame size of 2144 bytes is larger than 2048 bytes [-Werror=frame-larger-than=]
> 1659 | }
> | ^
The above is fixed today.
> drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c: In function 'dml32_ModeSupportAndSystemConfigurationFull':
> drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c:3799:1: error: the frame size of 2464 bytes is larger than 2048 bytes [-Werror=frame-larger-than=]
> 3799 | } // ModeSupportAndSystemConfigurationFull
> | ^
This is still here, but the frame size is down to 2336.
> Using the amdgpu tree from next-20220718 fixes the problem, so I have
> done that for today.
--
Cheers,
Stephen Rothwell
Hi all,
On Wed, 20 Jul 2022 12:47:32 +1000 Stephen Rothwell <[email protected]> wrote:
>
> > drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c: In function 'dml32_ModeSupportAndSystemConfigurationFull':
> > drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c:3799:1: error: the frame size of 2464 bytes is larger than 2048 bytes [-Werror=frame-larger-than=]
> > 3799 | } // ModeSupportAndSystemConfigurationFull
> > | ^
>
> This is still here, but the frame size is down to 2336.
Today it is down to 2128.
--
Cheers,
Stephen Rothwell
Hi all,
On Thu, 21 Jul 2022 12:16:18 +1000 Stephen Rothwell <[email protected]> wrote:
>
> Hi all,
>
> On Wed, 20 Jul 2022 12:47:32 +1000 Stephen Rothwell <[email protected]> wrote:
> >
> > > drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c: In function 'dml32_ModeSupportAndSystemConfigurationFull':
> > > drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c:3799:1: error: the frame size of 2464 bytes is larger than 2048 bytes [-Werror=frame-larger-than=]
> > > 3799 | } // ModeSupportAndSystemConfigurationFull
> > > | ^
> >
> > This is still here, but the frame size is down to 2336.
>
> Today it is down to 2128.
And today we are back up to 2152. I can only imagine that maybe things
are being inlined?
My compiler (in case it matters):
$ x86_64-linux-gnu-gcc --version
x86_64-linux-gnu-gcc (Debian 11.2.0-9) 11.2.0
--
Cheers,
Stephen Rothwell
On Thu, Jul 21, 2022 at 10:52 PM Stephen Rothwell <[email protected]> wrote:
>
> Hi all,
>
> On Thu, 21 Jul 2022 12:16:18 +1000 Stephen Rothwell <[email protected]> wrote:
> >
> > Hi all,
> >
> > On Wed, 20 Jul 2022 12:47:32 +1000 Stephen Rothwell <[email protected]> wrote:
> > >
> > > > drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c: In function 'dml32_ModeSupportAndSystemConfigurationFull':
> > > > drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c:3799:1: error: the frame size of 2464 bytes is larger than 2048 bytes [-Werror=frame-larger-than=]
> > > > 3799 | } // ModeSupportAndSystemConfigurationFull
> > > > | ^
> > >
> > > This is still here, but the frame size is down to 2336.
> >
> > Today it is down to 2128.
>
> And today we are back up to 2152. I can only imagine that maybe things
> are being inlined?
This is driving me crazy, there is almost nothing left on the stack at
this point.
Alex
>
> My compiler (in case it matters):
>
> $ x86_64-linux-gnu-gcc --version
> x86_64-linux-gnu-gcc (Debian 11.2.0-9) 11.2.0
>
> --
> Cheers,
> Stephen Rothwell