Add Versal device support.
v2:
- Sort compatible strings alphabetically in DT bindings.
- Reorganize new config and CAPS order to be cleaner.
Harini Katakam (2):
net: macb: Sort CAPS flags by bit positions
net: macb: Update tsu clk usage in runtime suspend/resume for Versal
Radhey Shyam Pandey (1):
dt-bindings: net: cdns,macb: Add versal compatible string
.../devicetree/bindings/net/cdns,macb.yaml | 1 +
drivers/net/ethernet/cadence/macb.h | 5 +++--
drivers/net/ethernet/cadence/macb_main.c | 17 +++++++++++++++--
3 files changed, 19 insertions(+), 4 deletions(-)
--
2.17.1
From: Radhey Shyam Pandey <[email protected]>
Add versal compatible string.
Signed-off-by: Radhey Shyam Pandey <[email protected]>
Signed-off-by: Harini Katakam <[email protected]>
---
v2:
Sort compatible string alphabetically.
Documentation/devicetree/bindings/net/cdns,macb.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml b/Documentation/devicetree/bindings/net/cdns,macb.yaml
index 9c92156869b2..762deccd3640 100644
--- a/Documentation/devicetree/bindings/net/cdns,macb.yaml
+++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml
@@ -20,6 +20,7 @@ properties:
- items:
- enum:
+ - cdns,versal-gem # Xilinx Versal
- cdns,zynq-gem # Xilinx Zynq-7xxx SoC
- cdns,zynqmp-gem # Xilinx Zynq Ultrascale+ MPSoC
- const: cdns,gem # Generic
--
2.17.1
On 22/07/2022 13:03, Harini Katakam wrote:
> From: Radhey Shyam Pandey <[email protected]>
>
> Add versal compatible string.
Acked-by: Krzysztof Kozlowski <[email protected]>
Best regards,
Krzysztof
Hello:
This series was applied to netdev/net-next.git (master)
by David S. Miller <[email protected]>:
On Fri, 22 Jul 2022 16:33:27 +0530 you wrote:
> Add Versal device support.
>
> v2:
> - Sort compatible strings alphabetically in DT bindings.
> - Reorganize new config and CAPS order to be cleaner.
>
> Harini Katakam (2):
> net: macb: Sort CAPS flags by bit positions
> net: macb: Update tsu clk usage in runtime suspend/resume for Versal
>
> [...]
Here is the summary with links:
- [v2,1/3] dt-bindings: net: cdns,macb: Add versal compatible string
https://git.kernel.org/netdev/net-next/c/f1fa61b04530
- [v2,2/3] net: macb: Sort CAPS flags by bit positions
https://git.kernel.org/netdev/net-next/c/1d3ded642535
- [v2,3/3] net: macb: Update tsu clk usage in runtime suspend/resume for Versal
https://git.kernel.org/netdev/net-next/c/8a1c9753f165
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
On 25/07/2022 21:33, Rob Herring wrote:
> On Fri, Jul 22, 2022 at 04:33:28PM +0530, Harini Katakam wrote:
>> From: Radhey Shyam Pandey <[email protected]>
>>
>> Add versal compatible string.
>>
>> Signed-off-by: Radhey Shyam Pandey <[email protected]>
>> Signed-off-by: Harini Katakam <[email protected]>
>> ---
>> v2:
>> Sort compatible string alphabetically.
>>
>> Documentation/devicetree/bindings/net/cdns,macb.yaml | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml b/Documentation/devicetree/bindings/net/cdns,macb.yaml
>> index 9c92156869b2..762deccd3640 100644
>> --- a/Documentation/devicetree/bindings/net/cdns,macb.yaml
>> +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml
>> @@ -20,6 +20,7 @@ properties:
>>
>> - items:
>> - enum:
>> + - cdns,versal-gem # Xilinx Versal
>> - cdns,zynq-gem # Xilinx Zynq-7xxx SoC
>> - cdns,zynqmp-gem # Xilinx Zynq Ultrascale+ MPSoC
>
> Uh, how did we start this pattern? The vendor here is Xilinx, not
> Cadence. It should be xlnx,versal-gem instead.
I missed that piece entirely... Un-ack.
Best regards,
Krzysztof
On Fri, Jul 22, 2022 at 04:33:28PM +0530, Harini Katakam wrote:
> From: Radhey Shyam Pandey <[email protected]>
>
> Add versal compatible string.
>
> Signed-off-by: Radhey Shyam Pandey <[email protected]>
> Signed-off-by: Harini Katakam <[email protected]>
> ---
> v2:
> Sort compatible string alphabetically.
>
> Documentation/devicetree/bindings/net/cdns,macb.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml b/Documentation/devicetree/bindings/net/cdns,macb.yaml
> index 9c92156869b2..762deccd3640 100644
> --- a/Documentation/devicetree/bindings/net/cdns,macb.yaml
> +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml
> @@ -20,6 +20,7 @@ properties:
>
> - items:
> - enum:
> + - cdns,versal-gem # Xilinx Versal
> - cdns,zynq-gem # Xilinx Zynq-7xxx SoC
> - cdns,zynqmp-gem # Xilinx Zynq Ultrascale+ MPSoC
Uh, how did we start this pattern? The vendor here is Xilinx, not
Cadence. It should be xlnx,versal-gem instead.
> - const: cdns,gem # Generic
> --
> 2.17.1
>
>
Hi Rob, Krzysztof,
> -----Original Message-----
> From: Krzysztof Kozlowski <[email protected]>
> Sent: Tuesday, July 26, 2022 1:10 AM
> To: Rob Herring <[email protected]>; Harini Katakam
> <[email protected]>
> Cc: [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected]; Katakam, Harini
> <[email protected]>; [email protected];
> [email protected]
> Subject: Re: [PATCH v2 1/3] dt-bindings: net: cdns,macb: Add versal
> compatible string
>
> On 25/07/2022 21:33, Rob Herring wrote:
> > On Fri, Jul 22, 2022 at 04:33:28PM +0530, Harini Katakam wrote:
<snip>
> >>
> >> - items:
> >> - enum:
> >> + - cdns,versal-gem # Xilinx Versal
> >> - cdns,zynq-gem # Xilinx Zynq-7xxx SoC
> >> - cdns,zynqmp-gem # Xilinx Zynq Ultrascale+ MPSoC
> >
> > Uh, how did we start this pattern? The vendor here is Xilinx, not
> > Cadence. It should be xlnx,versal-gem instead.
I'm not sure how the pattern started but I see that all the early versions
of compatible strings added (Xilinx, Atmel, Microchip) has cdns prefix.
Links for reference:
https://lore.kernel.org/lkml/[email protected]/
https://lore.kernel.org/lkml/[email protected]/
https://lore.kernel.org/lkml/[email protected]/
I can switch to xlnx,versal-gem now.
Regards,
Harini