Hi All,
This patch series is a subset of [0] as patches 1-4 have been already
picked up by Geert for v5.21. Patch 1 introduces macros for NMI/IRQ0-7,
second patch updates the binding doc and the third patch adds PHY
interrupt support for ETH{0,1}.
v2->v3:
* Added a new file irqc-rzg2l.h to include macros as suggested by
Biju and Geert.
* Updated binding doc
* Updated rzg2l-smarc-som.dtsi to include the header
v1->v2:
* Fixed review comments pointed by Geert
v1: [0]
[0] https://patchwork.kernel.org/project/linux-renesas-soc/cover/
[email protected]/
Cheers,
Prabhakar
Lad Prabhakar (3):
dt-bindings: interrupt-controller: Add macros for NMI and IRQ0-7
interrupts present on RZ/G2L SoC
dt-bindings: interrupt-controller: renesas,rzg2l-irqc: Update
description for '#interrupt-cells' property
arm64: dts: renesas: rzg2l-smarc-som: Add PHY interrupt support for
ETH{0/1}
.../renesas,rzg2l-irqc.yaml | 5 ++--
.../boot/dts/renesas/rzg2l-smarc-som.dtsi | 11 ++++++--
.../interrupt-controller/irqc-rzg2l.h | 25 +++++++++++++++++++
3 files changed, 37 insertions(+), 4 deletions(-)
create mode 100644 include/dt-bindings/interrupt-controller/irqc-rzg2l.h
--
2.25.1
Update description for '#interrupt-cells' property to utilize the
RZG2L_{NMI,IRQX} for the first cell defined in the
include/dt-bindings/interrupt-controller/irqc-rzg2l.h file.
Signed-off-by: Lad Prabhakar <[email protected]>
---
v3:
* New patch
---
.../bindings/interrupt-controller/renesas,rzg2l-irqc.yaml | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/interrupt-controller/renesas,rzg2l-irqc.yaml b/Documentation/devicetree/bindings/interrupt-controller/renesas,rzg2l-irqc.yaml
index 33b90e975e33..ea7db3618b23 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/renesas,rzg2l-irqc.yaml
+++ b/Documentation/devicetree/bindings/interrupt-controller/renesas,rzg2l-irqc.yaml
@@ -31,8 +31,9 @@ properties:
- const: renesas,rzg2l-irqc
'#interrupt-cells':
- description: The first cell should contain external interrupt number (IRQ0-7) and the
- second cell is used to specify the flag.
+ description: The first cell should contain a macro RZG2L_{NMI,IRQX} included in the
+ include/dt-bindings/interrupt-controller/irqc-rzg2l.h and the second
+ cell is used to specify the flag.
const: 2
'#address-cells':
--
2.25.1
On Fri, 22 Jul 2022 16:11:54 +0100,
Lad Prabhakar <[email protected]> wrote:
>
> Update description for '#interrupt-cells' property to utilize the
> RZG2L_{NMI,IRQX} for the first cell defined in the
> include/dt-bindings/interrupt-controller/irqc-rzg2l.h file.
>
> Signed-off-by: Lad Prabhakar <[email protected]>
> ---
> v3:
> * New patch
> ---
> .../bindings/interrupt-controller/renesas,rzg2l-irqc.yaml | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/renesas,rzg2l-irqc.yaml b/Documentation/devicetree/bindings/interrupt-controller/renesas,rzg2l-irqc.yaml
> index 33b90e975e33..ea7db3618b23 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/renesas,rzg2l-irqc.yaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/renesas,rzg2l-irqc.yaml
> @@ -31,8 +31,9 @@ properties:
> - const: renesas,rzg2l-irqc
>
> '#interrupt-cells':
> - description: The first cell should contain external interrupt number (IRQ0-7) and the
> - second cell is used to specify the flag.
> + description: The first cell should contain a macro RZG2L_{NMI,IRQX} included in the
> + include/dt-bindings/interrupt-controller/irqc-rzg2l.h and the second
> + cell is used to specify the flag.
I think a binding should be self describing, and not rely on an opaque
macro. Mentioning that there is a macro that encodes it is fine, but
the values are what matter, specially when considering that other OSs
could (and should be able to) write their own DTs from scratch without
depending on something that is very much Linux-specific.
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
Hi Marc,
On Sun, Jul 24, 2022 at 1:01 PM Marc Zyngier <[email protected]> wrote:
> On Fri, 22 Jul 2022 16:11:54 +0100,
> Lad Prabhakar <[email protected]> wrote:
> >
> > Update description for '#interrupt-cells' property to utilize the
> > RZG2L_{NMI,IRQX} for the first cell defined in the
> > include/dt-bindings/interrupt-controller/irqc-rzg2l.h file.
> >
> > Signed-off-by: Lad Prabhakar <[email protected]>
> > ---
> > v3:
> > * New patch
> > --- a/Documentation/devicetree/bindings/interrupt-controller/renesas,rzg2l-irqc.yaml
> > +++ b/Documentation/devicetree/bindings/interrupt-controller/renesas,rzg2l-irqc.yaml
> > @@ -31,8 +31,9 @@ properties:
> > - const: renesas,rzg2l-irqc
> >
> > '#interrupt-cells':
> > - description: The first cell should contain external interrupt number (IRQ0-7) and the
> > - second cell is used to specify the flag.
> > + description: The first cell should contain a macro RZG2L_{NMI,IRQX} included in the
> > + include/dt-bindings/interrupt-controller/irqc-rzg2l.h and the second
> > + cell is used to specify the flag.
>
> I think a binding should be self describing, and not rely on an opaque
> macro. Mentioning that there is a macro that encodes it is fine, but
> the values are what matter, specially when considering that other OSs
> could (and should be able to) write their own DTs from scratch without
> depending on something that is very much Linux-specific.
The macros are not Linux-specific, and are part of the bindings.
But the only hard dependency on <dt-bindings/interrupt-controller/irqc-rzg2l.h>
is the DT source file describing the board.
Reviewed-by: Geert Uytterhoeven <[email protected]>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Hi Marc,
On Thu, Aug 11, 2022 at 4:50 PM Geert Uytterhoeven <[email protected]> wrote:
> On Sun, Jul 24, 2022 at 1:01 PM Marc Zyngier <[email protected]> wrote:
> > On Fri, 22 Jul 2022 16:11:54 +0100,
> > Lad Prabhakar <[email protected]> wrote:
> > >
> > > Update description for '#interrupt-cells' property to utilize the
> > > RZG2L_{NMI,IRQX} for the first cell defined in the
> > > include/dt-bindings/interrupt-controller/irqc-rzg2l.h file.
> > >
> > > Signed-off-by: Lad Prabhakar <[email protected]>
> > > ---
> > > v3:
> > > * New patch
>
> > > --- a/Documentation/devicetree/bindings/interrupt-controller/renesas,rzg2l-irqc.yaml
> > > +++ b/Documentation/devicetree/bindings/interrupt-controller/renesas,rzg2l-irqc.yaml
> > > @@ -31,8 +31,9 @@ properties:
> > > - const: renesas,rzg2l-irqc
> > >
> > > '#interrupt-cells':
> > > - description: The first cell should contain external interrupt number (IRQ0-7) and the
> > > - second cell is used to specify the flag.
> > > + description: The first cell should contain a macro RZG2L_{NMI,IRQX} included in the
> > > + include/dt-bindings/interrupt-controller/irqc-rzg2l.h and the second
> > > + cell is used to specify the flag.
> >
> > I think a binding should be self describing, and not rely on an opaque
> > macro. Mentioning that there is a macro that encodes it is fine, but
> > the values are what matter, specially when considering that other OSs
> > could (and should be able to) write their own DTs from scratch without
> > depending on something that is very much Linux-specific.
>
> The macros are not Linux-specific, and are part of the bindings.
> But the only hard dependency on <dt-bindings/interrupt-controller/irqc-rzg2l.h>
> is the DT source file describing the board.
>
> Reviewed-by: Geert Uytterhoeven <[email protected]>
Looks like this fell through the cracks?
The two other patches from this series were applied in v6.1.
Note that the current DT bindings are incorrect, as they do not take into
account that the value of zero is used to represent the NMI.
Fixes: 96fed779d3d4cb3c ("dt-bindings: interrupt-controller: Add
Renesas RZ/G2L Interrupt Controller")
Should we resend instead?
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
On Fri, 08 Sep 2023 10:31:35 +0100,
Geert Uytterhoeven <[email protected]> wrote:
>
> Hi Marc,
>
> On Thu, Aug 11, 2022 at 4:50 PM Geert Uytterhoeven <[email protected]> wrote:
> > On Sun, Jul 24, 2022 at 1:01 PM Marc Zyngier <[email protected]> wrote:
> > > On Fri, 22 Jul 2022 16:11:54 +0100,
> > > Lad Prabhakar <[email protected]> wrote:
> > > >
> > > > Update description for '#interrupt-cells' property to utilize the
> > > > RZG2L_{NMI,IRQX} for the first cell defined in the
> > > > include/dt-bindings/interrupt-controller/irqc-rzg2l.h file.
> > > >
> > > > Signed-off-by: Lad Prabhakar <[email protected]>
> > > > ---
> > > > v3:
> > > > * New patch
> >
> > > > --- a/Documentation/devicetree/bindings/interrupt-controller/renesas,rzg2l-irqc.yaml
> > > > +++ b/Documentation/devicetree/bindings/interrupt-controller/renesas,rzg2l-irqc.yaml
> > > > @@ -31,8 +31,9 @@ properties:
> > > > - const: renesas,rzg2l-irqc
> > > >
> > > > '#interrupt-cells':
> > > > - description: The first cell should contain external interrupt number (IRQ0-7) and the
> > > > - second cell is used to specify the flag.
> > > > + description: The first cell should contain a macro RZG2L_{NMI,IRQX} included in the
> > > > + include/dt-bindings/interrupt-controller/irqc-rzg2l.h and the second
> > > > + cell is used to specify the flag.
> > >
> > > I think a binding should be self describing, and not rely on an opaque
> > > macro. Mentioning that there is a macro that encodes it is fine, but
> > > the values are what matter, specially when considering that other OSs
> > > could (and should be able to) write their own DTs from scratch without
> > > depending on something that is very much Linux-specific.
> >
> > The macros are not Linux-specific, and are part of the bindings.
> > But the only hard dependency on <dt-bindings/interrupt-controller/irqc-rzg2l.h>
> > is the DT source file describing the board.
> >
> > Reviewed-by: Geert Uytterhoeven <[email protected]>
>
> Looks like this fell through the cracks?
> The two other patches from this series were applied in v6.1.
>
> Note that the current DT bindings are incorrect, as they do not take into
> account that the value of zero is used to represent the NMI.
>
> Fixes: 96fed779d3d4cb3c ("dt-bindings: interrupt-controller: Add
> Renesas RZ/G2L Interrupt Controller")
>
> Should we resend instead?
It applied cleanly to v6.6-rc1, so there should be no need.
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
The following commit has been merged into the irq/irqchip-fixes branch of irqchip:
Commit-ID: cfa1f9db6d6088118ef311c0927c66072665b47e
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/cfa1f9db6d6088118ef311c0927c66072665b47e
Author: Lad Prabhakar <[email protected]>
AuthorDate: Fri, 22 Jul 2022 16:11:54 +01:00
Committer: Marc Zyngier <[email protected]>
CommitterDate: Tue, 12 Sep 2023 13:40:52 +01:00
dt-bindings: interrupt-controller: renesas,rzg2l-irqc: Update description for '#interrupt-cells' property
Update description for '#interrupt-cells' property to utilize the
RZG2L_{NMI,IRQX} for the first cell defined in the
include/dt-bindings/interrupt-controller/irqc-rzg2l.h file.
Signed-off-by: Lad Prabhakar <[email protected]>
Reviewed-by: Geert Uytterhoeven <[email protected]>
Fixes: 96fed779d3d4cb3c ("dt-bindings: interrupt-controller: Add Renesas RZ/G2L Interrupt Controller")
Signed-off-by: Marc Zyngier <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
---
Documentation/devicetree/bindings/interrupt-controller/renesas,rzg2l-irqc.yaml | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/interrupt-controller/renesas,rzg2l-irqc.yaml b/Documentation/devicetree/bindings/interrupt-controller/renesas,rzg2l-irqc.yaml
index 33b90e9..ea7db36 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/renesas,rzg2l-irqc.yaml
+++ b/Documentation/devicetree/bindings/interrupt-controller/renesas,rzg2l-irqc.yaml
@@ -31,8 +31,9 @@ properties:
- const: renesas,rzg2l-irqc
'#interrupt-cells':
- description: The first cell should contain external interrupt number (IRQ0-7) and the
- second cell is used to specify the flag.
+ description: The first cell should contain a macro RZG2L_{NMI,IRQX} included in the
+ include/dt-bindings/interrupt-controller/irqc-rzg2l.h and the second
+ cell is used to specify the flag.
const: 2
'#address-cells':