2022-07-25 02:45:24

by XU pengfei

Subject: [PATCH 1/1] clk/qcom/drivers/sm6350: qcom_cc_really_probe(pdev, &gcc_sm6350_desc, regmap) is assigned an extra semicolon

I think this semicolon could be deleted.

Signed-off-by: XU pengfei <[email protected]>
---
drivers/clk/qcom/gcc-sm6350.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/qcom/gcc-sm6350.c b/drivers/clk/qcom/gcc-sm6350.c
index a4f7fba70393..69412400efa4 100644
--- a/drivers/clk/qcom/gcc-sm6350.c
+++ b/drivers/clk/qcom/gcc-sm6350.c
@@ -2558,7 +2558,7 @@ static int gcc_sm6350_probe(struct platform_device *pdev)
if (ret)
return ret;

- return qcom_cc_really_probe(pdev, &gcc_sm6350_desc, regmap);;
+ return qcom_cc_really_probe(pdev, &gcc_sm6350_desc, regmap);
}

static struct platform_driver gcc_sm6350_driver = {
--
2.18.2

2022-07-25 07:42:57

by Abel Vesa

Subject: Re: [PATCH 1/1] clk/qcom/drivers/sm6350: qcom_cc_really_probe(pdev, &gcc_sm6350_desc, regmap) is assigned an extra semicolon

On 22-07-25 10:16:23, XU pengfei wrote:
> I think this semicolon could be deleted.
>
> Signed-off-by: XU pengfei <[email protected]>

Thank you for your patch, but there are a few things you should change.

First of, the subject line should be something like:

clk: qcom: gcc-sm6350: Remove unnecessary semicolon

Then, your commit message should say what it does.
Maybe something like:

Remove unnecessary semicolon after qcom_cc_really_probe call.

Also, there is a document that describes everthing about submitting
patches. See Documentation/process/submitting-patches.rst.

> ---
> drivers/clk/qcom/gcc-sm6350.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/qcom/gcc-sm6350.c b/drivers/clk/qcom/gcc-sm6350.c
> index a4f7fba70393..69412400efa4 100644
> --- a/drivers/clk/qcom/gcc-sm6350.c
> +++ b/drivers/clk/qcom/gcc-sm6350.c
> @@ -2558,7 +2558,7 @@ static int gcc_sm6350_probe(struct platform_device *pdev)
> if (ret)
> return ret;
>
> - return qcom_cc_really_probe(pdev, &gcc_sm6350_desc, regmap);;
> + return qcom_cc_really_probe(pdev, &gcc_sm6350_desc, regmap);
> }
>
> static struct platform_driver gcc_sm6350_driver = {
> --
> 2.18.2
>

2022-07-28 09:43:12

by XU pengfei

Subject: [PATCH v2] clk/qcom/gcc-sm6350: Remove unnecessary semicolon

Remove unnecessary semicolon after qcom_cc_really_probe call.

Signed-off-by: XU pengfei <[email protected]>
---
drivers/clk/qcom/gcc-sm6350.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/qcom/gcc-sm6350.c b/drivers/clk/qcom/gcc-sm6350.c
index a4f7fba70393..69412400efa4 100644
--- a/drivers/clk/qcom/gcc-sm6350.c
+++ b/drivers/clk/qcom/gcc-sm6350.c
@@ -2558,7 +2558,7 @@ static int gcc_sm6350_probe(struct platform_device *pdev)
if (ret)
return ret;

- return qcom_cc_really_probe(pdev, &gcc_sm6350_desc, regmap);;
+ return qcom_cc_really_probe(pdev, &gcc_sm6350_desc, regmap);
}

static struct platform_driver gcc_sm6350_driver = {
--
2.18.2

2022-07-28 12:20:17

by Abel Vesa

Subject: Re: [PATCH v2] clk/qcom/gcc-sm6350: Remove unnecessary semicolon

On 22-07-28 17:07:20, XU pengfei wrote:
> Remove unnecessary semicolon after qcom_cc_really_probe call.
>
> Signed-off-by: XU pengfei <[email protected]>
> ---

Thanks for this new version, but there are still some issues with it.

First of, don't use slashes in subject. Use semicolons instead.
Have a look at how other commits look like by running:

git log --oneline drivers/clk/qcom/

Also, do not send subsquent versions of a patch as a reply to old ones.


> drivers/clk/qcom/gcc-sm6350.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/qcom/gcc-sm6350.c b/drivers/clk/qcom/gcc-sm6350.c
> index a4f7fba70393..69412400efa4 100644
> --- a/drivers/clk/qcom/gcc-sm6350.c
> +++ b/drivers/clk/qcom/gcc-sm6350.c
> @@ -2558,7 +2558,7 @@ static int gcc_sm6350_probe(struct platform_device *pdev)
> if (ret)
> return ret;
>
> - return qcom_cc_really_probe(pdev, &gcc_sm6350_desc, regmap);;
> + return qcom_cc_really_probe(pdev, &gcc_sm6350_desc, regmap);
> }
>
> static struct platform_driver gcc_sm6350_driver = {
> --
> 2.18.2
>