2022-07-28 05:26:13

by Jarkko Sakkinen

Subject: [PATCH] KVM: SVM: Dump Virtual Machine Save Area (VMSA) to klog

As Virtual Machine Save Area (VMSA) is essential in troubleshooting
attestation, dump it to the klog with the KERN_DEBUG level of priority.

Cc: Jarkko Sakkinen <[email protected]>
Suggested-by: Harald Hoyer <[email protected]>
Signed-off-by: Jarkko Sakkinen <[email protected]>
---
arch/x86/kvm/svm/sev.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c
index 0c240ed04f96..6d44aaba321a 100644
--- a/arch/x86/kvm/svm/sev.c
+++ b/arch/x86/kvm/svm/sev.c
@@ -603,6 +603,9 @@ static int sev_es_sync_vmsa(struct vcpu_svm *svm)
save->xss = svm->vcpu.arch.ia32_xss;
save->dr6 = svm->vcpu.arch.dr6;

+ pr_debug("Virtual Machine Save Area (VMSA):\n");
+ print_hex_dump(KERN_CONT, "", DUMP_PREFIX_NONE, 16, 1, save, sizeof(*save), false);
+
return 0;
}

--
2.37.1

2022-07-28 15:40:16

by Paolo Bonzini

Subject: Re: [PATCH] KVM: SVM: Dump Virtual Machine Save Area (VMSA) to klog

On 7/28/22 07:09, Jarkko Sakkinen wrote:
> As Virtual Machine Save Area (VMSA) is essential in troubleshooting
> attestation, dump it to the klog with the KERN_DEBUG level of priority.
>
> Cc: Jarkko Sakkinen <[email protected]>
> Suggested-by: Harald Hoyer <[email protected]>
> Signed-off-by: Jarkko Sakkinen <[email protected]>
> ---
> arch/x86/kvm/svm/sev.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c
> index 0c240ed04f96..6d44aaba321a 100644
> --- a/arch/x86/kvm/svm/sev.c
> +++ b/arch/x86/kvm/svm/sev.c
> @@ -603,6 +603,9 @@ static int sev_es_sync_vmsa(struct vcpu_svm *svm)
> save->xss = svm->vcpu.arch.ia32_xss;
> save->dr6 = svm->vcpu.arch.dr6;
>
> + pr_debug("Virtual Machine Save Area (VMSA):\n");
> + print_hex_dump(KERN_CONT, "", DUMP_PREFIX_NONE, 16, 1, save, sizeof(*save), false);
> +
> return 0;
> }
>

Queued, thanks.

Paolo

2022-07-29 12:22:35

by Jarkko Sakkinen

Subject: Re: [PATCH] KVM: SVM: Dump Virtual Machine Save Area (VMSA) to klog

On Thu, Jul 28, 2022 at 05:15:43PM +0200, Paolo Bonzini wrote:
> On 7/28/22 07:09, Jarkko Sakkinen wrote:
> > As Virtual Machine Save Area (VMSA) is essential in troubleshooting
> > attestation, dump it to the klog with the KERN_DEBUG level of priority.
> >
> > Cc: Jarkko Sakkinen <[email protected]>
> > Suggested-by: Harald Hoyer <[email protected]>
> > Signed-off-by: Jarkko Sakkinen <[email protected]>
> > ---
> > arch/x86/kvm/svm/sev.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c
> > index 0c240ed04f96..6d44aaba321a 100644
> > --- a/arch/x86/kvm/svm/sev.c
> > +++ b/arch/x86/kvm/svm/sev.c
> > @@ -603,6 +603,9 @@ static int sev_es_sync_vmsa(struct vcpu_svm *svm)
> > save->xss = svm->vcpu.arch.ia32_xss;
> > save->dr6 = svm->vcpu.arch.dr6;
> > + pr_debug("Virtual Machine Save Area (VMSA):\n");
> > + print_hex_dump(KERN_CONT, "", DUMP_PREFIX_NONE, 16, 1, save, sizeof(*save), false);
> > +
> > return 0;
> > }
>
> Queued, thanks.
>
> Paolo

Ugh, I made a mistake, sorry.

It should have been:

print_hex_dump(KERN_DEBUG, "VMSA:", DUMP_PREFIX_NONE, 16, 1, save, sizeof(*save), false);

I sent wrong version of the patch.

BR, Jarkko