2022-07-29 15:38:28

by Sidong Yang

Subject: [PATCH] staging: pi433: fix wrong comment

The comment should describe the error when user calls rf69_write_fifo()
not rf69_write_fifo().

Signed-off-by: Sidong Yang <[email protected]>
---
drivers/staging/pi433/rf69.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index 659c8c1b38fd..8c7fab6a46bb 100644
--- a/drivers/staging/pi433/rf69.c
+++ b/drivers/staging/pi433/rf69.c
@@ -816,7 +816,7 @@ int rf69_write_fifo(struct spi_device *spi, u8 *buffer, unsigned int size)

if (size > FIFO_SIZE) {
dev_dbg(&spi->dev,
- "read fifo: passed in buffer bigger then internal buffer\n");
+ "write fifo: passed in buffer bigger then internal buffer\n");
return -EMSGSIZE;
}

--
2.30.2

2022-07-29 16:10:14

by Greg KH

Subject: Re: [PATCH] staging: pi433: fix wrong comment

On Fri, Jul 29, 2022 at 04:25:54PM +0100, Sidong Yang wrote:
> The comment should describe the error when user calls rf69_write_fifo()
> not rf69_write_fifo().
>
> Signed-off-by: Sidong Yang <[email protected]>
> ---
> drivers/staging/pi433/rf69.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
> index 659c8c1b38fd..8c7fab6a46bb 100644
> --- a/drivers/staging/pi433/rf69.c
> +++ b/drivers/staging/pi433/rf69.c
> @@ -816,7 +816,7 @@ int rf69_write_fifo(struct spi_device *spi, u8 *buffer, unsigned int size)
>
> if (size > FIFO_SIZE) {
> dev_dbg(&spi->dev,
> - "read fifo: passed in buffer bigger then internal buffer\n");
> + "write fifo: passed in buffer bigger then internal buffer\n");

This is not a comment.