2022-07-30 09:45:38

by Akhil P Oommen

[permalink] [raw]
Subject: [PATCH v3 6/8] drm/msm/adreno: Remove a WARN() during runtime_suspend

WARN(gpu->active_submits) during runtime_suspend doesn't make sense now
because we force runtime suspend during a gpu recovery when there are
active submissions pending.

Signed-off-by: Akhil P Oommen <[email protected]>
---

(no changes since v1)

drivers/gpu/drm/msm/adreno/adreno_device.c | 7 -------
1 file changed, 7 deletions(-)

diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/msm/adreno/adreno_device.c
index 8706bcd..d1e1e8e 100644
--- a/drivers/gpu/drm/msm/adreno/adreno_device.c
+++ b/drivers/gpu/drm/msm/adreno/adreno_device.c
@@ -610,13 +610,6 @@ static int adreno_runtime_suspend(struct device *dev)
{
struct msm_gpu *gpu = dev_to_gpu(dev);

- /*
- * We should be holding a runpm ref, which will prevent
- * runtime suspend. In the system suspend path, we've
- * already waited for active jobs to complete.
- */
- WARN_ON_ONCE(gpu->active_submits);
-
return gpu->funcs->pm_suspend(gpu);
}

--
2.7.4