2022-08-02 07:47:27

by studentxswpy

[permalink] [raw]
Subject: [PATCH] scsi: sun3x_esp: check the return value of ioremap() in esp_sun3x_probe()

From: Xie Shaowen <[email protected]>

The function ioremap() in esp_sun3x_probe() can fail, so
its return value should be checked.

Fixes: 4bdc0d676a643 ("remove ioremap_nocache and devm_ioremap_nocache")
Reported-by: Hacash Robot <[email protected]>
Signed-off-by: Xie Shaowen <[email protected]>
---
drivers/scsi/sun3x_esp.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/scsi/sun3x_esp.c b/drivers/scsi/sun3x_esp.c
index d3489ac7ab28..cc670b50a357 100644
--- a/drivers/scsi/sun3x_esp.c
+++ b/drivers/scsi/sun3x_esp.c
@@ -199,6 +199,8 @@ static int esp_sun3x_probe(struct platform_device *dev)
goto fail_unmap_regs;

esp->dma_regs = ioremap(res->start, 0x10);
+ if (!esp->dma_regs)
+ goto fail_unmap_regs;

esp->command_block = dma_alloc_coherent(esp->dev, 16,
&esp->command_block_dma,
--
2.25.1