2022-08-11 23:16:33

by Jaegeuk Kim

Subject: [PATCH] f2fs: zoned device does not support ATGC

ATGC is using SSR which violates zoned device.

Signed-off-by: Jaegeuk Kim <[email protected]>
---
fs/f2fs/super.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 2451623c05a7..212ec2b4926b 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -1298,6 +1298,10 @@ static int parse_options(struct super_block *sb, char *options, bool is_remount)
F2FS_OPTION(sbi).discard_unit =
DISCARD_UNIT_SECTION;
}
+ if (test_opt(sbi, ATGC)) {
+ f2fs_err(sbi, "Zoned block device doesn't support ATGC.");
+ return -EINVAL;
+ }
}

#ifdef CONFIG_F2FS_FS_COMPRESSION
--
2.37.1.559.g78731f0fdb-goog

2022-08-15 03:46:14

by Chao Yu

Subject: Re: [f2fs-dev] [PATCH] f2fs: zoned device does not support ATGC

On 2022/8/12 6:54, Jaegeuk Kim wrote:
> ATGC is using SSR which violates zoned device. >
> Signed-off-by: Jaegeuk Kim <[email protected]>
> ---
> fs/f2fs/super.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 2451623c05a7..212ec2b4926b 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -1298,6 +1298,10 @@ static int parse_options(struct super_block *sb, char *options, bool is_remount)
> F2FS_OPTION(sbi).discard_unit =
> DISCARD_UNIT_SECTION;
> }
> + if (test_opt(sbi, ATGC)) {
> + f2fs_err(sbi, "Zoned block device doesn't support ATGC.");
> + return -EINVAL;
> + }

ATGC is incompatible with LFS mode, we can check f2fs_lfs_mode() and ATGC
mountoption instead, as zoned device depends on LFS mode.

Thanks,

> }
>
> #ifdef CONFIG_F2FS_FS_COMPRESSION

2022-08-20 00:01:05

by Jaegeuk Kim

Subject: Re: [PATCH v2] f2fs: LFS mode does not support ATGC

ATGC is using SSR which violates LFS mode used by zoned device.

Signed-off-by: Jaegeuk Kim <[email protected]>
---

Change log from v1:
- check LFS mode

fs/f2fs/super.c | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 2451623c05a7..fe462484f5fa 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -1342,6 +1342,11 @@ static int parse_options(struct super_block *sb, char *options, bool is_remount)
return -EINVAL;
}

+ if (test_opt(sbi, ATGC) && f2fs_lfs_mode(sbi)) {
+ f2fs_err(sbi, "LFS not compatible with ATGC");
+ return -EINVAL;
+ }
+
if (f2fs_sb_has_readonly(sbi) && !f2fs_readonly(sbi->sb)) {
f2fs_err(sbi, "Allow to mount readonly mode only");
return -EROFS;
--
2.37.1.595.g718a3a8f04-goog

2022-08-20 03:05:24

by Chao Yu

Subject: Re: [f2fs-dev] [PATCH v2] f2fs: LFS mode does not support ATGC

On 2022/8/20 7:53, Jaegeuk Kim wrote:
> ATGC is using SSR which violates LFS mode used by zoned device.
>
> Signed-off-by: Jaegeuk Kim <[email protected]>

Reviewed-by: Chao Yu <[email protected]>

Thanks,