2022-08-12 17:39:01

by Tim Harvey

[permalink] [raw]
Subject: [PATCH 1/6] arm64: dts: imx8mp-venice-gw74xx: fix CAN STBY polarity

The CAN STBY poarlity is active-low. Specify it as such.

Fixes: 7899eb6cb15d ("arm64: dts: imx: Add i.MX8M Plus Gateworks gw7400 dts support")
Signed-off-by: Tim Harvey <[email protected]>
---
arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
index 521215520a0f..de17021df53f 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
@@ -123,8 +123,8 @@ reg_can2_stby: regulator-can2-stby {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_reg_can>;
regulator-name = "can2_stby";
- gpio = <&gpio3 19 GPIO_ACTIVE_HIGH>;
- enable-active-high;
+ gpio = <&gpio3 19 GPIO_ACTIVE_LOW>;
+ enable-active-low;
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
};
--
2.25.1


2022-08-12 17:39:14

by Tim Harvey

[permalink] [raw]
Subject: [PATCH 5/6] arm64: dts: imx8mp-venice-gw74xx: add cpu-supply node for cpufreq

Add regulator config for cpu-supply in order to support cpufreq.

Signed-off-by: Tim Harvey <[email protected]>
---
.../dts/freescale/imx8mp-venice-gw74xx.dts | 18 +++++++++++++++++-
1 file changed, 17 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
index cb4cf293a7b7..bfc480aaf54d 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
@@ -142,6 +142,22 @@ reg_wifi_en: regulator-wifi-en {
};
};

+&A53_0 {
+ cpu-supply = <&reg_arm>;
+};
+
+&A53_1 {
+ cpu-supply = <&reg_arm>;
+};
+
+&A53_2 {
+ cpu-supply = <&reg_arm>;
+};
+
+&A53_3 {
+ cpu-supply = <&reg_arm>;
+};
+
/* off-board header */
&ecspi2 {
pinctrl-names = "default";
@@ -362,7 +378,7 @@ BUCK1 {
regulator-ramp-delay = <3125>;
};

- BUCK2 {
+ reg_arm: BUCK2 {
regulator-name = "BUCK2";
regulator-min-microvolt = <720000>;
regulator-max-microvolt = <1025000>;
--
2.25.1

2022-08-12 17:39:51

by Tim Harvey

[permalink] [raw]
Subject: [PATCH 6/6] arm64: dts: imx8mp-venice-gw74xx: add WiFi/BT module support

The GW74xx supports an on-board Laird Connectivity Sterling LWB5+ module
which uses a Cypress CYW4373W chip to provide 1x1 802.11 a/b/g/n/ac +
Bluetooth 5.2.

Add the proper device-tree nodes for it.

Signed-off-by: Tim Harvey <[email protected]>
---
.../dts/freescale/imx8mp-venice-gw74xx.dts | 38 +++++++++++++++++--
1 file changed, 35 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
index bfc480aaf54d..47866d4e5444 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
@@ -135,10 +135,10 @@ reg_wifi_en: regulator-wifi-en {
compatible = "regulator-fixed";
regulator-name = "wl";
gpio = <&gpio3 9 GPIO_ACTIVE_HIGH>;
- startup-delay-us = <100>;
+ startup-delay-us = <70000>;
enable-active-high;
- regulator-min-microvolt = <1800000>;
- regulator-max-microvolt = <1800000>;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
};
};

@@ -577,6 +577,21 @@ &uart2 {
status = "okay";
};

+/* bluetooth HCI */
+&uart3 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_uart3>, <&pinctrl_uart3_gpio>;
+ cts-gpios = <&gpio3 21 GPIO_ACTIVE_LOW>;
+ rts-gpios = <&gpio3 22 GPIO_ACTIVE_LOW>;
+ uart-has-rtscts;
+ status = "okay";
+
+ bluetooth {
+ compatible = "brcm,bcm4330-bt";
+ shutdown-gpios = <&gpio3 8 GPIO_ACTIVE_HIGH>;
+ };
+};
+
&uart4 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_uart4>;
@@ -617,6 +632,23 @@ &usb_dwc3_1 {
status = "okay";
};

+/* SDIO WiFi */
+&usdhc1 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_usdhc1>;
+ bus-width = <4>;
+ non-removable;
+ vmmc-supply = <&reg_wifi_en>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "okay";
+
+ wifi@0 {
+ compatible = "cypress,cyw4373-fmac";
+ reg = <0>;
+ };
+};
+
/* eMMC */
&usdhc3 {
assigned-clocks = <&clk IMX8MP_CLK_USDHC3>;
--
2.25.1

2022-08-12 18:00:55

by Fabio Estevam

[permalink] [raw]
Subject: Re: [PATCH 1/6] arm64: dts: imx8mp-venice-gw74xx: fix CAN STBY polarity

Hi Tim,

On Fri, Aug 12, 2022 at 2:35 PM Tim Harvey <[email protected]> wrote:

> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> index 521215520a0f..de17021df53f 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> @@ -123,8 +123,8 @@ reg_can2_stby: regulator-can2-stby {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_reg_can>;
> regulator-name = "can2_stby";
> - gpio = <&gpio3 19 GPIO_ACTIVE_HIGH>;
> - enable-active-high;
> + gpio = <&gpio3 19 GPIO_ACTIVE_LOW>;
> + enable-active-low;

This 'enable-active-low' property does not exist. Just remove it.

2022-08-12 19:23:38

by Tim Harvey

[permalink] [raw]
Subject: Re: [PATCH 1/6] arm64: dts: imx8mp-venice-gw74xx: fix CAN STBY polarity

On Fri, Aug 12, 2022 at 10:51 AM Fabio Estevam <[email protected]> wrote:
>
> Hi Tim,
>
> On Fri, Aug 12, 2022 at 2:35 PM Tim Harvey <[email protected]> wrote:
>
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> > index 521215520a0f..de17021df53f 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> > @@ -123,8 +123,8 @@ reg_can2_stby: regulator-can2-stby {
> > pinctrl-names = "default";
> > pinctrl-0 = <&pinctrl_reg_can>;
> > regulator-name = "can2_stby";
> > - gpio = <&gpio3 19 GPIO_ACTIVE_HIGH>;
> > - enable-active-high;
> > + gpio = <&gpio3 19 GPIO_ACTIVE_LOW>;
> > + enable-active-low;
>
> This 'enable-active-low' property does not exist. Just remove it.

Fabio,

Thanks - I see now that for active-low you just omit the
'enable-active-high' prop. I will send a new version.

Thanks,

Tim