2022-08-15 01:33:42

by sunliming

Subject: [PATCH] iio: light: cm32181: make cm32181_pm_ops static

This symbol is not used outside of cm32181.c, so marks it static.

Fixes the following sparse warnings:
>> drivers/iio/light/cm32181.c:508:1: sparse: sparse: symbol 'cm32181_pm_ops'
was not declared. Should it be static?

Reported-by: kernel test robot <[email protected]>
Signed-off-by: sunliming <[email protected]>
---
drivers/iio/light/cm32181.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/light/cm32181.c b/drivers/iio/light/cm32181.c
index edbe6a3138d0..001055d09750 100644
--- a/drivers/iio/light/cm32181.c
+++ b/drivers/iio/light/cm32181.c
@@ -505,7 +505,7 @@ static int cm32181_resume(struct device *dev)
cm32181->conf_regs[CM32181_REG_ADDR_CMD]);
}

-DEFINE_SIMPLE_DEV_PM_OPS(cm32181_pm_ops, cm32181_suspend, cm32181_resume);
+static DEFINE_SIMPLE_DEV_PM_OPS(cm32181_pm_ops, cm32181_suspend, cm32181_resume);

static const struct of_device_id cm32181_of_match[] = {
{ .compatible = "capella,cm3218" },
--
2.25.1

2022-08-20 11:57:35

by Jonathan Cameron

Subject: Re: [PATCH] iio: light: cm32181: make cm32181_pm_ops static

On Mon, 15 Aug 2022 09:29:30 +0800
sunliming <[email protected]> wrote:

> This symbol is not used outside of cm32181.c, so marks it static.
>
> Fixes the following sparse warnings:
> >> drivers/iio/light/cm32181.c:508:1: sparse: sparse: symbol 'cm32181_pm_ops'
> was not declared. Should it be static?
>
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: sunliming <[email protected]>

Applied. Thanks,
> ---
> drivers/iio/light/cm32181.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/light/cm32181.c b/drivers/iio/light/cm32181.c
> index edbe6a3138d0..001055d09750 100644
> --- a/drivers/iio/light/cm32181.c
> +++ b/drivers/iio/light/cm32181.c
> @@ -505,7 +505,7 @@ static int cm32181_resume(struct device *dev)
> cm32181->conf_regs[CM32181_REG_ADDR_CMD]);
> }
>
> -DEFINE_SIMPLE_DEV_PM_OPS(cm32181_pm_ops, cm32181_suspend, cm32181_resume);
> +static DEFINE_SIMPLE_DEV_PM_OPS(cm32181_pm_ops, cm32181_suspend, cm32181_resume);
>
> static const struct of_device_id cm32181_of_match[] = {
> { .compatible = "capella,cm3218" },