2022-08-15 14:31:13

by José Expósito

Subject: [PATCH RESEND] HID: uclogic: Add missing suffix for digitalizers

The Pen (0x02) application usage was changed to Digitalizer (0x01) in
commit f7d8e387d9ae ("HID: uclogic: Switch to Digitizer usage for
styluses"). However, a suffix was not selected for the new usage.

Handle the digitalizer application usage in uclogic_input_configured()
and add the required suffix.

Signed-off-by: José Expósito <[email protected]>

---

Kindly resending this patch so it doesn't get lost after the merge
window.
---
drivers/hid/hid-uclogic-core.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/hid/hid-uclogic-core.c b/drivers/hid/hid-uclogic-core.c
index 47a17375c7fc..ff46604ef1d8 100644
--- a/drivers/hid/hid-uclogic-core.c
+++ b/drivers/hid/hid-uclogic-core.c
@@ -153,6 +153,7 @@ static int uclogic_input_configured(struct hid_device *hdev,
suffix = "Pad";
break;
case HID_DG_PEN:
+ case HID_DG_DIGITIZER:
suffix = "Pen";
break;
case HID_CP_CONSUMER_CONTROL:
--
2.25.1

2022-08-25 08:27:52

by Jiri Kosina

Subject: Re: [PATCH RESEND] HID: uclogic: Add missing suffix for digitalizers

On Mon, 15 Aug 2022, José Expósito wrote:

> The Pen (0x02) application usage was changed to Digitalizer (0x01) in
> commit f7d8e387d9ae ("HID: uclogic: Switch to Digitizer usage for
> styluses"). However, a suffix was not selected for the new usage.
>
> Handle the digitalizer application usage in uclogic_input_configured()
> and add the required suffix.
>
> Signed-off-by: José Expósito <[email protected]>
>
> ---
>
> Kindly resending this patch so it doesn't get lost after the merge
> window.
> ---
> drivers/hid/hid-uclogic-core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hid/hid-uclogic-core.c b/drivers/hid/hid-uclogic-core.c
> index 47a17375c7fc..ff46604ef1d8 100644
> --- a/drivers/hid/hid-uclogic-core.c
> +++ b/drivers/hid/hid-uclogic-core.c
> @@ -153,6 +153,7 @@ static int uclogic_input_configured(struct hid_device *hdev,
> suffix = "Pad";
> break;
> case HID_DG_PEN:
> + case HID_DG_DIGITIZER:
> suffix = "Pen";
> break;
> case HID_CP_CONSUMER_CONTROL:

Applied, thanks.

--
Jiri Kosina
SUSE Labs