2022-08-15 15:46:56

by Stefan Binding

Subject: [PATCH v1] ALSA: hda: cs35l41: Clarify support for CSC3551 without _DSD Properties

For devices which use HID CSC3551, correct ACPI _DSD properties are
required to be able support those systems.
Add error message to clarify this.

Signed-off-by: Stefan Binding <[email protected]>
---
sound/pci/hda/cs35l41_hda.c | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/sound/pci/hda/cs35l41_hda.c b/sound/pci/hda/cs35l41_hda.c
index 129bffb431c2..b9d94f3a5b99 100644
--- a/sound/pci/hda/cs35l41_hda.c
+++ b/sound/pci/hda/cs35l41_hda.c
@@ -1163,6 +1163,11 @@ static int cs35l41_no_acpi_dsd(struct cs35l41_hda *cs35l41, struct device *physd
hw_cfg->gpio1.func = CS35l41_VSPK_SWITCH;
hw_cfg->gpio1.valid = true;
} else {
+ /*
+ * Note: CLSA010(0/1) are special cases which use a slightly different design.
+ * All other HIDs e.g. CSC3551 require valid ACPI _DSD properties to be supported.
+ */
+ dev_err(cs35l41->dev, "Error: ACPI _DSD Properties are missing for HID %s.", hid);
hw_cfg->valid = false;
hw_cfg->gpio1.valid = false;
hw_cfg->gpio2.valid = false;
--
2.34.1

2022-08-15 16:38:24

by Takashi Iwai

Subject: Re: [PATCH v1] ALSA: hda: cs35l41: Clarify support for CSC3551 without _DSD Properties

On Mon, 15 Aug 2022 17:28:44 +0200,
Stefan Binding wrote:
>
> For devices which use HID CSC3551, correct ACPI _DSD properties are
> required to be able support those systems.
> Add error message to clarify this.
>
> Signed-off-by: Stefan Binding <[email protected]>
> ---
> sound/pci/hda/cs35l41_hda.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/sound/pci/hda/cs35l41_hda.c b/sound/pci/hda/cs35l41_hda.c
> index 129bffb431c2..b9d94f3a5b99 100644
> --- a/sound/pci/hda/cs35l41_hda.c
> +++ b/sound/pci/hda/cs35l41_hda.c
> @@ -1163,6 +1163,11 @@ static int cs35l41_no_acpi_dsd(struct cs35l41_hda *cs35l41, struct device *physd
> hw_cfg->gpio1.func = CS35l41_VSPK_SWITCH;
> hw_cfg->gpio1.valid = true;
> } else {
> + /*
> + * Note: CLSA010(0/1) are special cases which use a slightly different design.
> + * All other HIDs e.g. CSC3551 require valid ACPI _DSD properties to be supported.
> + */
> + dev_err(cs35l41->dev, "Error: ACPI _DSD Properties are missing for HID %s.", hid);

A newline is missing at the end of the string?


Takashi