2022-08-16 17:42:54

by Xin Gao

Subject: [PATCH] perf metrics: Variable type completion

'unsigned int' is better than 'unsigned'.

Signed-off-by: Xin Gao <[email protected]>
---
tools/perf/util/metricgroup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.c
index ee8fcfa115e5..8926de9617ef 100644
--- a/tools/perf/util/metricgroup.c
+++ b/tools/perf/util/metricgroup.c
@@ -1620,7 +1620,7 @@ int metricgroup__copy_metric_events(struct evlist *evlist, struct cgroup *cgrp,
struct rblist *new_metric_events,
struct rblist *old_metric_events)
{
- unsigned i;
+ unsigned int i;

for (i = 0; i < rblist__nr_entries(old_metric_events); i++) {
struct rb_node *nd;
--
2.30.2

2022-08-22 14:30:56

by Arnaldo Carvalho de Melo

Subject: Re: [PATCH] perf metrics: Variable type completion

Em Wed, Aug 17, 2022 at 01:38:04AM +0800, Xin Gao escreveu:
> 'unsigned int' is better than 'unsigned'.

Thanks, applied.

- Arnaldo


> Signed-off-by: Xin Gao <[email protected]>
> ---
> tools/perf/util/metricgroup.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.c
> index ee8fcfa115e5..8926de9617ef 100644
> --- a/tools/perf/util/metricgroup.c
> +++ b/tools/perf/util/metricgroup.c
> @@ -1620,7 +1620,7 @@ int metricgroup__copy_metric_events(struct evlist *evlist, struct cgroup *cgrp,
> struct rblist *new_metric_events,
> struct rblist *old_metric_events)
> {
> - unsigned i;
> + unsigned int i;
>
> for (i = 0; i < rblist__nr_entries(old_metric_events); i++) {
> struct rb_node *nd;
> --
> 2.30.2

--

- Arnaldo