The capabilities enabled for multi-link are required as part of the
programming sequences, even when a stream uses a single link we still
use the syncArm/syncGo sequences. Therefore the TODO is no longer
necessary.
Suggested-by: Pierre-Louis Bossart <[email protected]>
Signed-off-by: Khalid Masum <[email protected]>
---
Previous discussions:
- v1 Link: https://lore.kernel.org/lkml/[email protected]/
Changes since v1:
- Remove the todo, leave rest of the code as is
- Update commit message
drivers/soundwire/bus.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c
index 8d4000664fa3..18158825a6d8 100644
--- a/drivers/soundwire/bus.c
+++ b/drivers/soundwire/bus.c
@@ -75,7 +75,6 @@ int sdw_bus_master_add(struct sdw_bus *bus, struct device *parent,
/*
* Initialize multi_link flag
- * TODO: populate this flag by reading property from FW node
*/
bus->multi_link = false;
if (bus->ops->read_prop) {
--
2.37.1
On 8/16/22 19:59, Khalid Masum wrote:
> The capabilities enabled for multi-link are required as part of the
> programming sequences, even when a stream uses a single link we still
> use the syncArm/syncGo sequences. Therefore the TODO is no longer
> necessary.
>
> Suggested-by: Pierre-Louis Bossart <[email protected]>
> Signed-off-by: Khalid Masum <[email protected]>
the title of your patch should be something like
soundwire: intel: remove unnecessary TODO
so that the patch scope and context is clearly identified.
> ---
> Previous discussions:
> - v1 Link: https://lore.kernel.org/lkml/[email protected]/
>
> Changes since v1:
> - Remove the todo, leave rest of the code as is
> - Update commit message
>
> drivers/soundwire/bus.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c
> index 8d4000664fa3..18158825a6d8 100644
> --- a/drivers/soundwire/bus.c
> +++ b/drivers/soundwire/bus.c
> @@ -75,7 +75,6 @@ int sdw_bus_master_add(struct sdw_bus *bus, struct device *parent,
>
> /*
> * Initialize multi_link flag
> - * TODO: populate this flag by reading property from FW node
> */
> bus->multi_link = false;
> if (bus->ops->read_prop) {
On August 17, 2022 12:31:20 PM GMT+06:00, Pierre-Louis Bossart <[email protected]> wrote:
>
>
>On 8/16/22 19:59, Khalid Masum wrote:
>> The capabilities enabled for multi-link are required as part of the
>> programming sequences, even when a stream uses a single link we still
>> use the syncArm/syncGo sequences. Therefore the TODO is no longer
>> necessary.
>>
>> Suggested-by: Pierre-Louis Bossart <[email protected]>
>> Signed-off-by: Khalid Masum <[email protected]>
>
>the title of your patch should be something like
>
>soundwire: intel: remove unnecessary TODO
>
You are right. I shall send the patch with the title fixed soon.
-- Khalid Masum