2022-08-18 21:50:11

by Wolfram Sang

Subject: [PATCH] parisc: move from strlcpy with unused retval to strscpy

Follow the advice of the below link and prefer 'strscpy' in this
subsystem. Conversion is 1:1 because the return value is not used.
Generated by a coccinelle script.

Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/
Signed-off-by: Wolfram Sang <[email protected]>
---
drivers/parisc/led.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/parisc/led.c b/drivers/parisc/led.c
index 1e4a5663d011..d4be9d2ee74d 100644
--- a/drivers/parisc/led.c
+++ b/drivers/parisc/led.c
@@ -646,7 +646,7 @@ int lcd_print( const char *str )
cancel_delayed_work_sync(&led_task);

/* copy display string to buffer for procfs */
- strlcpy(lcd_text, str, sizeof(lcd_text));
+ strscpy(lcd_text, str, sizeof(lcd_text));

/* Set LCD Cursor to 1st character */
gsc_writeb(lcd_info.reset_cmd1, LCD_CMD_REG);
--
2.35.1

2022-08-19 20:36:19

by Helge Deller

Subject: Re: [PATCH] parisc: move from strlcpy with unused retval to strscpy

On 8/18/22 23:00, Wolfram Sang wrote:
> Follow the advice of the below link and prefer 'strscpy' in this
> subsystem. Conversion is 1:1 because the return value is not used.
> Generated by a coccinelle script.
>
> Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/
> Signed-off-by: Wolfram Sang <[email protected]>

applied to parisc git tree.
Thanks!
Helge

> ---
> drivers/parisc/led.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/parisc/led.c b/drivers/parisc/led.c
> index 1e4a5663d011..d4be9d2ee74d 100644
> --- a/drivers/parisc/led.c
> +++ b/drivers/parisc/led.c
> @@ -646,7 +646,7 @@ int lcd_print( const char *str )
> cancel_delayed_work_sync(&led_task);
>
> /* copy display string to buffer for procfs */
> - strlcpy(lcd_text, str, sizeof(lcd_text));
> + strscpy(lcd_text, str, sizeof(lcd_text));
>
> /* Set LCD Cursor to 1st character */
> gsc_writeb(lcd_info.reset_cmd1, LCD_CMD_REG);