2022-08-23 16:08:09

by Jilin Yuan

Subject: [PATCH] drm/msm: fix repeated words in comments

Delete the redundant word 'one'.

Signed-off-by: Jilin Yuan <[email protected]>
---
drivers/gpu/drm/msm/msm_gem.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/msm/msm_gem.h b/drivers/gpu/drm/msm/msm_gem.h
index c75d3b879a53..e300c70e8904 100644
--- a/drivers/gpu/drm/msm/msm_gem.h
+++ b/drivers/gpu/drm/msm/msm_gem.h
@@ -118,7 +118,7 @@ struct msm_gem_object {
* An object is either:
* inactive - on priv->inactive_dontneed or priv->inactive_willneed
* (depending on purgeability status)
- * active - on one one of the gpu's active_list.. well, at
+ * active - on one of the gpu's active_list.. well, at
* least for now we don't have (I don't think) hw sync between
* 2d and 3d one devices which have both, meaning we need to
* block on submit if a bo is already on other ring
--
2.36.1

2022-08-26 09:54:51

by Dmitry Baryshkov

Subject: Re: [PATCH] drm/msm: fix repeated words in comments

On 23/08/2022 14:54, Jilin Yuan wrote:
> Delete the redundant word 'one'.

The whitespace is unnecessary.

>
> Signed-off-by: Jilin Yuan <[email protected]>

Reviewed-by: Dmitry Baryshkov <[email protected]>
Fixes: 7198e6b03155 ("drm/msm: add a3xx gpu support")


> ---
> drivers/gpu/drm/msm/msm_gem.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/msm_gem.h b/drivers/gpu/drm/msm/msm_gem.h
> index c75d3b879a53..e300c70e8904 100644
> --- a/drivers/gpu/drm/msm/msm_gem.h
> +++ b/drivers/gpu/drm/msm/msm_gem.h
> @@ -118,7 +118,7 @@ struct msm_gem_object {
> * An object is either:
> * inactive - on priv->inactive_dontneed or priv->inactive_willneed
> * (depending on purgeability status)
> - * active - on one one of the gpu's active_list.. well, at
> + * active - on one of the gpu's active_list.. well, at
> * least for now we don't have (I don't think) hw sync between
> * 2d and 3d one devices which have both, meaning we need to
> * block on submit if a bo is already on other ring

--
With best wishes
Dmitry

2022-08-27 16:52:21

by Rob Clark

Subject: Re: [PATCH] drm/msm: fix repeated words in comments

On Fri, Aug 26, 2022 at 2:43 AM Dmitry Baryshkov
<[email protected]> wrote:
>
> On 23/08/2022 14:54, Jilin Yuan wrote:
> > Delete the redundant word 'one'.
>
> The whitespace is unnecessary.
>
> >
> > Signed-off-by: Jilin Yuan <[email protected]>
>
> Reviewed-by: Dmitry Baryshkov <[email protected]>
> Fixes: 7198e6b03155 ("drm/msm: add a3xx gpu support")
>

jfyi, this comment (and associated list-head) is removed by:

https://patchwork.freedesktop.org/patch/496131/?series=105633&rev=4

BR,
-R

>
> > ---
> > drivers/gpu/drm/msm/msm_gem.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/msm/msm_gem.h b/drivers/gpu/drm/msm/msm_gem.h
> > index c75d3b879a53..e300c70e8904 100644
> > --- a/drivers/gpu/drm/msm/msm_gem.h
> > +++ b/drivers/gpu/drm/msm/msm_gem.h
> > @@ -118,7 +118,7 @@ struct msm_gem_object {
> > * An object is either:
> > * inactive - on priv->inactive_dontneed or priv->inactive_willneed
> > * (depending on purgeability status)
> > - * active - on one one of the gpu's active_list.. well, at
> > + * active - on one of the gpu's active_list.. well, at
> > * least for now we don't have (I don't think) hw sync between
> > * 2d and 3d one devices which have both, meaning we need to
> > * block on submit if a bo is already on other ring
>
> --
> With best wishes
> Dmitry
>