2022-08-25 12:58:17

by Pali Rohár

Subject: [PATCH] ARM: dts: turris-omnia: Add switch port 6 node

Switch port 6 is connected to eth0, so add appropriate device tree node for it.

Fixes: 26ca8b52d6e1 ("ARM: dts: add support for Turris Omnia")
Signed-off-by: Pali Rohár <[email protected]>
---
arch/arm/boot/dts/armada-385-turris-omnia.dts | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
index f655e9229d68..8215ffb6a795 100644
--- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
+++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
@@ -463,7 +463,17 @@
};
};

- /* port 6 is connected to eth0 */
+ ports@6 {
+ reg = <6>;
+ label = "cpu";
+ ethernet = <&eth0>;
+ phy-mode = "rgmii-id";
+
+ fixed-link {
+ speed = <1000>;
+ full-duplex;
+ };
+ };
};
};
};
--
2.20.1

2022-08-27 19:43:46

by Andrew Lunn

Subject: Re: [PATCH] ARM: dts: turris-omnia: Add switch port 6 node

On Thu, Aug 25, 2022 at 02:21:02PM +0200, Pali Roh?r wrote:
> Switch port 6 is connected to eth0, so add appropriate device tree node for it.
>
> Fixes: 26ca8b52d6e1 ("ARM: dts: add support for Turris Omnia")
> Signed-off-by: Pali Roh?r <[email protected]>
> ---
> arch/arm/boot/dts/armada-385-turris-omnia.dts | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> index f655e9229d68..8215ffb6a795 100644
> --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
> +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> @@ -463,7 +463,17 @@
> };
> };
>
> - /* port 6 is connected to eth0 */
> + ports@6 {
> + reg = <6>;
> + label = "cpu";
> + ethernet = <&eth0>;
> + phy-mode = "rgmii-id";
> +
> + fixed-link {
> + speed = <1000>;
> + full-duplex;
> + };
> + };

Hi Pali

I've not been following Vladimirs work on multiple CPU ports. Is it
clearly defined, both for old and new kernels, what happens where
there are multiple CPU ports defined?

Andrew

2022-08-27 20:52:16

by Andrew Lunn

Subject: Re: [PATCH] ARM: dts: turris-omnia: Add switch port 6 node

> > Hi Pali
> >
> > I've not been following Vladimirs work on multiple CPU ports. Is it
> > clearly defined, both for old and new kernels, what happens where
> > there are multiple CPU ports defined?
> >
> > Andrew
>
> Hello!
>
> On older kernel kernel versions just the first one cpu port works.

O.K, i was worried it might use the last "cpu" port found, and so
change things.

Reviewed-by: Andrew Lunn <[email protected]>

Andrew

2022-08-27 20:54:08

by Pali Rohár

Subject: Re: [PATCH] ARM: dts: turris-omnia: Add switch port 6 node

On Saturday 27 August 2022 20:41:59 Andrew Lunn wrote:
> On Thu, Aug 25, 2022 at 02:21:02PM +0200, Pali Rohár wrote:
> > Switch port 6 is connected to eth0, so add appropriate device tree node for it.
> >
> > Fixes: 26ca8b52d6e1 ("ARM: dts: add support for Turris Omnia")
> > Signed-off-by: Pali Rohár <[email protected]>
> > ---
> > arch/arm/boot/dts/armada-385-turris-omnia.dts | 12 +++++++++++-
> > 1 file changed, 11 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> > index f655e9229d68..8215ffb6a795 100644
> > --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
> > +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> > @@ -463,7 +463,17 @@
> > };
> > };
> >
> > - /* port 6 is connected to eth0 */
> > + ports@6 {
> > + reg = <6>;
> > + label = "cpu";
> > + ethernet = <&eth0>;
> > + phy-mode = "rgmii-id";
> > +
> > + fixed-link {
> > + speed = <1000>;
> > + full-duplex;
> > + };
> > + };
>
> Hi Pali
>
> I've not been following Vladimirs work on multiple CPU ports. Is it
> clearly defined, both for old and new kernels, what happens where
> there are multiple CPU ports defined?
>
> Andrew

Hello!

On older kernel kernel versions just the first one cpu port works. Like
if second node is not defined at all. So I sent this patch to have
complete HW definition in DTS, even when kernel does not support all
features yet.

2022-09-24 12:24:50

by Pali Rohár

Subject: Re: [PATCH] ARM: dts: turris-omnia: Add switch port 6 node

PING?

On Thursday 25 August 2022 14:21:02 Pali Rohár wrote:
> Switch port 6 is connected to eth0, so add appropriate device tree node for it.
>
> Fixes: 26ca8b52d6e1 ("ARM: dts: add support for Turris Omnia")
> Signed-off-by: Pali Rohár <[email protected]>
> ---
> arch/arm/boot/dts/armada-385-turris-omnia.dts | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> index f655e9229d68..8215ffb6a795 100644
> --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
> +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> @@ -463,7 +463,17 @@
> };
> };
>
> - /* port 6 is connected to eth0 */
> + ports@6 {
> + reg = <6>;
> + label = "cpu";
> + ethernet = <&eth0>;
> + phy-mode = "rgmii-id";
> +
> + fixed-link {
> + speed = <1000>;
> + full-duplex;
> + };
> + };
> };
> };
> };
> --
> 2.20.1
>

2022-09-24 14:46:25

by Andrew Lunn

Subject: Re: [PATCH] ARM: dts: turris-omnia: Add switch port 6 node

On Sat, Sep 24, 2022 at 02:14:00PM +0200, Pali Roh?r wrote:
> PING?

You would do better reposting, adding my Reviewed-by:.

My _guess_ would be, any patch which Gregory receives which already
has a reviewed-by: on it, will get picked up immediately.

Andrew

2022-11-01 23:03:35

by Pali Rohár

Subject: Re: [PATCH] ARM: dts: turris-omnia: Add switch port 6 node

PING?

On Thursday 25 August 2022 14:21:02 Pali Rohár wrote:
> Switch port 6 is connected to eth0, so add appropriate device tree node for it.
>
> Fixes: 26ca8b52d6e1 ("ARM: dts: add support for Turris Omnia")
> Signed-off-by: Pali Rohár <[email protected]>
> ---
> arch/arm/boot/dts/armada-385-turris-omnia.dts | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> index f655e9229d68..8215ffb6a795 100644
> --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
> +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> @@ -463,7 +463,17 @@
> };
> };
>
> - /* port 6 is connected to eth0 */
> + ports@6 {
> + reg = <6>;
> + label = "cpu";
> + ethernet = <&eth0>;
> + phy-mode = "rgmii-id";
> +
> + fixed-link {
> + speed = <1000>;
> + full-duplex;
> + };
> + };
> };
> };
> };
> --
> 2.20.1
>

2022-11-28 00:21:16

by Gregory CLEMENT

Subject: Re: [PATCH] ARM: dts: turris-omnia: Add switch port 6 node

Pali Rohár <[email protected]> writes:

> Switch port 6 is connected to eth0, so add appropriate device tree node for it.
>
> Fixes: 26ca8b52d6e1 ("ARM: dts: add support for Turris Omnia")
> Signed-off-by: Pali Rohár <[email protected]>

Applied on mvebu/dt

Thanks,

Gregory
> ---
> arch/arm/boot/dts/armada-385-turris-omnia.dts | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> index f655e9229d68..8215ffb6a795 100644
> --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
> +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> @@ -463,7 +463,17 @@
> };
> };
>
> - /* port 6 is connected to eth0 */
> + ports@6 {
> + reg = <6>;
> + label = "cpu";
> + ethernet = <&eth0>;
> + phy-mode = "rgmii-id";
> +
> + fixed-link {
> + speed = <1000>;
> + full-duplex;
> + };
> + };
> };
> };
> };
> --
> 2.20.1
>

--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com