2022-08-25 19:32:20

by Maya Matuszczyk

Subject: [PATCH] drm: panel-orientation-quirks: Add quirk for Aya Neo Air

From: Maya Matuszczyk <[email protected]>

Yet another x86 gaming handheld.

This one has many SKUs with quite a few of DMI strings,
so let's just use a catchall, just as with Aya Neo Next.

Signed-off-by: Maya Matuszczyk <[email protected]>
---
drivers/gpu/drm/drm_panel_orientation_quirks.c | 12 ++++++++++++
1 file changed, 12 insertions(+)

diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index fc1728d46ac2..0b011b615495 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -103,6 +103,12 @@ static const struct drm_dmi_panel_orientation_data lcd800x1280_rightside_up = {
.orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
};

+static const struct drm_dmi_panel_orientation_data lcd1080x1920_leftside_up = {
+ .width = 1080,
+ .height = 1920,
+ .orientation = DRM_MODE_PANEL_ORIENTATION_LEFT_UP,
+};
+
static const struct drm_dmi_panel_orientation_data lcd1200x1920_rightside_up = {
.width = 1200,
.height = 1920,
@@ -152,6 +158,12 @@ static const struct dmi_system_id orientation_data[] = {
DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "AYA NEO 2021"),
},
.driver_data = (void *)&lcd800x1280_rightside_up,
+ }, { /* AYA NEO AIR */
+ .matches = {
+ DMI_EXACT_MATCH(DMI_SYS_VENDOR, "AYANEO"),
+ DMI_MATCH(DMI_BOARD_NAME, "AIR"),
+ },
+ .driver_data = (void *)&lcd1080x1920_leftside_up,
}, { /* AYA NEO NEXT */
.matches = {
DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "AYANEO"),
--
2.37.2

2022-09-17 18:37:02

by Hans de Goede

Subject: Re: drm: panel-orientation-quirks: Add quirk for Aya Neo Air

Hi,

On 8/25/22 21:19, Maccraft123 wrote:
> From: Maya Matuszczyk <[email protected]>
>
> Yet another x86 gaming handheld.
>
> This one has many SKUs with quite a few of DMI strings,
> so let's just use a catchall, just as with Aya Neo Next.
>
> Signed-off-by: Maya Matuszczyk <[email protected]>

Thanks, I have pushed this out to drm-misc-next now.

Note for future drm_panel_orientation_quirks.c patches please Cc me,
I am not subscribed to dri-devel.

Regards,

Hans


> ---
> drivers/gpu/drm/drm_panel_orientation_quirks.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> index fc1728d46ac2..0b011b615495 100644
> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> @@ -103,6 +103,12 @@ static const struct drm_dmi_panel_orientation_data lcd800x1280_rightside_up = {
> .orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
> };
>
> +static const struct drm_dmi_panel_orientation_data lcd1080x1920_leftside_up = {
> + .width = 1080,
> + .height = 1920,
> + .orientation = DRM_MODE_PANEL_ORIENTATION_LEFT_UP,
> +};
> +
> static const struct drm_dmi_panel_orientation_data lcd1200x1920_rightside_up = {
> .width = 1200,
> .height = 1920,
> @@ -152,6 +158,12 @@ static const struct dmi_system_id orientation_data[] = {
> DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "AYA NEO 2021"),
> },
> .driver_data = (void *)&lcd800x1280_rightside_up,
> + }, { /* AYA NEO AIR */
> + .matches = {
> + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "AYANEO"),
> + DMI_MATCH(DMI_BOARD_NAME, "AIR"),
> + },
> + .driver_data = (void *)&lcd1080x1920_leftside_up,
> }, { /* AYA NEO NEXT */
> .matches = {
> DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "AYANEO"),

2022-09-17 19:47:59

by Maya Matuszczyk

Subject: Re: drm: panel-orientation-quirks: Add quirk for Aya Neo Air

Hey,

sob., 17 wrz 2022 o 20:00 Hans de Goede <[email protected]> napisał(a):
>
> Hi,
>
> On 8/25/22 21:19, Maccraft123 wrote:
> > From: Maya Matuszczyk <[email protected]>
> >
> > Yet another x86 gaming handheld.
> >
> > This one has many SKUs with quite a few of DMI strings,
> > so let's just use a catchall, just as with Aya Neo Next.
> >
> > Signed-off-by: Maya Matuszczyk <[email protected]>
>
> Thanks, I have pushed this out to drm-misc-next now.
>
> Note for future drm_panel_orientation_quirks.c patches please Cc me,
> I am not subscribed to dri-devel.
Yeah i forgot to Cc you on this patch, and had no idea how to bring it up.
I'll do my best to remember in future.
Thanks for picking this up!

Best Regards,
Maya Matuszczyk

>
> Regards,
>
> Hans
>
>
> > ---
> > drivers/gpu/drm/drm_panel_orientation_quirks.c | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > index fc1728d46ac2..0b011b615495 100644
> > --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > @@ -103,6 +103,12 @@ static const struct drm_dmi_panel_orientation_data lcd800x1280_rightside_up = {
> > .orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
> > };
> >
> > +static const struct drm_dmi_panel_orientation_data lcd1080x1920_leftside_up = {
> > + .width = 1080,
> > + .height = 1920,
> > + .orientation = DRM_MODE_PANEL_ORIENTATION_LEFT_UP,
> > +};
> > +
> > static const struct drm_dmi_panel_orientation_data lcd1200x1920_rightside_up = {
> > .width = 1200,
> > .height = 1920,
> > @@ -152,6 +158,12 @@ static const struct dmi_system_id orientation_data[] = {
> > DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "AYA NEO 2021"),
> > },
> > .driver_data = (void *)&lcd800x1280_rightside_up,
> > + }, { /* AYA NEO AIR */
> > + .matches = {
> > + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "AYANEO"),
> > + DMI_MATCH(DMI_BOARD_NAME, "AIR"),
> > + },
> > + .driver_data = (void *)&lcd1080x1920_leftside_up,
> > }, { /* AYA NEO NEXT */
> > .matches = {
> > DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "AYANEO"),
>