2022-08-27 07:31:45

by Wei Yongjun

[permalink] [raw]
Subject: [PATCH -next 0/2] power: supply: adp5061: some fixes from device mockup test

This series fixes some issues found by device mockup unittest, not
sure how about the real device.

Wei Yongjun (2):
power: supply: adp5061: fix out-of-bounds read in
adp5061_get_chg_type()
power: supply: adp5061: show unknown capacity_level as text

drivers/power/supply/adp5061.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)

--
2.34.1


2022-08-27 07:34:26

by Wei Yongjun

[permalink] [raw]
Subject: [PATCH -next 2/2] power: supply: adp5061: show unknown capacity_level as text

adp5061_get_battery_status() only defined show chg_status <= 4, others will
be show as '-1731902199' from /sys/class/power_supply/xx/capacity_level.
switch to show them as 'Unknown'.

Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/power/supply/adp5061.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/power/supply/adp5061.c b/drivers/power/supply/adp5061.c
index daee1161c305..fcf8ff0bc974 100644
--- a/drivers/power/supply/adp5061.c
+++ b/drivers/power/supply/adp5061.c
@@ -493,6 +493,9 @@ static int adp5061_get_battery_status(struct adp5061_state *st,
case 0x4: /* VBAT_SNS > VWEAK */
val->intval = POWER_SUPPLY_CAPACITY_LEVEL_NORMAL;
break;
+ default:
+ val->intval = POWER_SUPPLY_CAPACITY_LEVEL_UNKNOWN;
+ break;
}

return ret;
--
2.34.1

2022-09-05 11:56:19

by Hennerich, Michael

[permalink] [raw]
Subject: RE: [PATCH -next 2/2] power: supply: adp5061: show unknown capacity_level as text



> -----Original Message-----
> From: Wei Yongjun <[email protected]>
> Sent: Samstag, 27. August 2022 09:32
> To: Hennerich, Michael <[email protected]>; Sebastian
> Reichel <[email protected]>
> Cc: Wei Yongjun <[email protected]>; [email protected];
> [email protected]
> Subject: [PATCH -next 2/2] power: supply: adp5061: show unknown
> capacity_level as text
>
>
> adp5061_get_battery_status() only defined show chg_status <= 4, others will
> be show as '-1731902199' from /sys/class/power_supply/xx/capacity_level.
> switch to show them as 'Unknown'.
>
> Signed-off-by: Wei Yongjun <[email protected]>

Acked-by: Michael Hennerich <[email protected]>

> ---
> drivers/power/supply/adp5061.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/power/supply/adp5061.c
> b/drivers/power/supply/adp5061.c index daee1161c305..fcf8ff0bc974
> 100644
> --- a/drivers/power/supply/adp5061.c
> +++ b/drivers/power/supply/adp5061.c
> @@ -493,6 +493,9 @@ static int adp5061_get_battery_status(struct
> adp5061_state *st,
> case 0x4: /* VBAT_SNS > VWEAK */
> val->intval = POWER_SUPPLY_CAPACITY_LEVEL_NORMAL;
> break;
> + default:
> + val->intval = POWER_SUPPLY_CAPACITY_LEVEL_UNKNOWN;
> + break;
> }
>
> return ret;
> --
> 2.34.1

2022-09-12 11:28:19

by Sebastian Reichel

[permalink] [raw]
Subject: Re: [PATCH -next 0/2] power: supply: adp5061: some fixes from device mockup test

Hi,

On Sat, Aug 27, 2022 at 07:32:22AM +0000, Wei Yongjun wrote:
> This series fixes some issues found by device mockup unittest, not
> sure how about the real device.
>
> Wei Yongjun (2):
> power: supply: adp5061: fix out-of-bounds read in
> adp5061_get_chg_type()
> power: supply: adp5061: show unknown capacity_level as text
>
> drivers/power/supply/adp5061.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)

Thanks, I queued both patches into power-supply's for-next branch.

-- Sebastian

Attachments:
(No filename) (539.00 B)
 signature.asc (849.00 B)
 Download all attachments