2022-09-01 10:44:40

by Valentina Goncharenko

Subject: [PATCH] ALSA: asihpi - Remove useless code in hpi_meter_get_peak()

The hpi_meter_get_peak() function contains the expression
"hm.obj_index = hm.obj_index", which does not carry any semantic load.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 719f82d3987a ("ALSA: Add support of AudioScience ASI boards")
Signed-off-by: Valentina Goncharenko <[email protected]>
---
sound/pci/asihpi/hpifunc.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/sound/pci/asihpi/hpifunc.c b/sound/pci/asihpi/hpifunc.c
index 1de05383126a..24047fafef51 100644
--- a/sound/pci/asihpi/hpifunc.c
+++ b/sound/pci/asihpi/hpifunc.c
@@ -2020,7 +2020,6 @@ u16 hpi_meter_get_peak(u32 h_control, short an_peakdB[HPI_MAX_CHANNELS]
HPI_CONTROL_GET_STATE);
if (hpi_handle_indexes(h_control, &hm.adapter_index, &hm.obj_index))
return HPI_ERROR_INVALID_HANDLE;
- hm.obj_index = hm.obj_index;
hm.u.c.attribute = HPI_METER_PEAK;

hpi_send_recv(&hm, &hr);
--
2.25.1

2022-09-01 13:16:10

by Takashi Iwai

Subject: Re: [PATCH] ALSA: asihpi - Remove useless code in hpi_meter_get_peak()

On Thu, 01 Sep 2022 12:28:14 +0200,
Valentina Goncharenko wrote:
>
> The hpi_meter_get_peak() function contains the expression
> "hm.obj_index = hm.obj_index", which does not carry any semantic load.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: 719f82d3987a ("ALSA: Add support of AudioScience ASI boards")
> Signed-off-by: Valentina Goncharenko <[email protected]>

Thanks, applied.


Takashi