2022-09-02 03:33:32

by CGEL

Subject: [PATCH linux-next] Driver: r8188eu: Remove the unneeded result variable Return 0 instead of storing it in another redundant variable.

From: lufengchang <[email protected]>

Reported-by: Zeal-Robot <[email protected]>
Signed-off-by: lufengchang <[email protected]>
---
drivers/staging/r8188eu/hal/rtl8188eu_xmit.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c b/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c
index 8e4a5acc0b18..6d1f56d1f9d7 100644
--- a/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c
+++ b/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c
@@ -149,7 +149,6 @@ static void fill_txdesc_phy(struct pkt_attrib *pattrib, __le32 *pdw)

static s32 update_txdesc(struct xmit_frame *pxmitframe, u8 *pmem, s32 sz, u8 bagg_pkt)
{
- int pull = 0;
uint qsel;
u8 data_rate, pwr_status, offset;
struct adapter *adapt = pxmitframe->padapter;
@@ -295,7 +294,7 @@ static s32 update_txdesc(struct xmit_frame *pxmitframe, u8 *pmem, s32 sz, u8 bag
ODM_SetTxAntByTxInfo_88E(&haldata->odmpriv, pmem, pattrib->mac_id);

rtl8188eu_cal_txdesc_chksum(ptxdesc);
- return pull;
+ return 0;
}

/* for non-agg data frame or management frame */
--
2.25.1

2022-09-02 05:57:38

by Greg Kroah-Hartman

Subject: Re: [PATCH linux-next] Driver: r8188eu: Remove the unneeded result variable Return 0 instead of storing it in another redundant variable.

On Fri, Sep 02, 2022 at 03:26:28AM +0000, [email protected] wrote:
> From: lufengchang <[email protected]>
>
> Reported-by: Zeal-Robot <[email protected]>

As stated in the past numerous times, I am no longer accepting patches
from this "tool" unless you provide the needed information that I have
asked for. Please work with your managers to fix up your development
process, this is not acceptable.

greg k-h

2022-09-02 09:28:08

by Dan Carpenter

Subject: Re: [PATCH linux-next] Driver: r8188eu: Remove the unneeded result variable Return 0 instead of storing it in another redundant variable.

On Fri, Sep 02, 2022 at 03:26:28AM +0000, [email protected] wrote:
> From: lufengchang <[email protected]>
>
> Reported-by: Zeal-Robot <[email protected]>
> Signed-off-by: lufengchang <[email protected]>
> ---

There is a lot wrong with the format of this patch.
1) The subsystem prefix
2) The blank line after the subject
3) Line wrapping at 75 chars
4) Your name is not capitalized
5) Greg doesn't like Zeal-Robot tags.

regards,
dan carpenter

2022-09-02 09:52:53

by Greg Kroah-Hartman

Subject: Re: [PATCH linux-next] Driver: r8188eu: Remove the unneeded result variable Return 0 instead of storing it in another redundant variable.

On Fri, Sep 02, 2022 at 11:54:46AM +0300, Dan Carpenter wrote:
> On Fri, Sep 02, 2022 at 03:26:28AM +0000, [email protected] wrote:
> > From: lufengchang <[email protected]>
> >
> > Reported-by: Zeal-Robot <[email protected]>
> > Signed-off-by: lufengchang <[email protected]>
> > ---
>
> There is a lot wrong with the format of this patch.
> 1) The subsystem prefix
> 2) The blank line after the subject
> 3) Line wrapping at 75 chars
> 4) Your name is not capitalized
> 5) Greg doesn't like Zeal-Robot tags.

I don't mind the tags, what I mind is that the users of this tool are
not following what is documented in
Documentation/process/researcher-guidelines.rst when using it.

thanks,

greg k-h