2022-09-05 10:38:26

by Miaohe Lin

Subject: [PATCH] blk-mq: remove unneeded needs_restart check

If code reaches here, needs_restart must be true. Remove this unneeded
needs_restart check. No functional change intended.

Signed-off-by: Miaohe Lin <[email protected]>
---
block/blk-mq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/blk-mq.c b/block/blk-mq.c
index b9f6989cb5bd..be7de99622a2 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -1992,7 +1992,7 @@ bool blk_mq_dispatch_rq_list(struct blk_mq_hw_ctx *hctx, struct list_head *list,
if (!needs_restart ||
(no_tag && list_empty_careful(&hctx->dispatch_wait.entry)))
blk_mq_run_hw_queue(hctx, true);
- else if (needs_restart && needs_resource)
+ else if (needs_resource)
blk_mq_delay_run_hw_queue(hctx, BLK_MQ_RESOURCE_DELAY);

blk_mq_update_dispatch_busy(hctx, true);
--
2.23.0

2022-09-05 18:16:23

by Jens Axboe

Subject: Re: [PATCH] blk-mq: remove unneeded needs_restart check

On Mon, 5 Sep 2022 18:19:50 +0800, Miaohe Lin wrote:
> If code reaches here, needs_restart must be true. Remove this unneeded
> needs_restart check. No functional change intended.
>
>

Applied, thanks!

[1/1] blk-mq: remove unneeded needs_restart check
commit: 6d5e8d21e8997b0efa409e46db22a27b5cbba6aa

Best regards,
--
Jens Axboe