2022-09-05 15:15:11

by Deyan Wang

Subject: [PATCH 1/1] arm64: preempt: Add NEED_RESCHED to the preempt_count()

From: Deyan Wang <[email protected]>

preempt_count() will be checked in preempt_schedule_irq(),
we need check if NEED_RESCHED in preempt point.

Signed-off-by: Deyan Wang <[email protected]>
---
arch/arm64/include/asm/preempt.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/include/asm/preempt.h b/arch/arm64/include/asm/preempt.h
index 0159b625cc7f..083b0fd3c52a 100644
--- a/arch/arm64/include/asm/preempt.h
+++ b/arch/arm64/include/asm/preempt.h
@@ -10,7 +10,7 @@

static inline int preempt_count(void)
{
- return READ_ONCE(current_thread_info()->preempt.count);
+ return READ_ONCE(current_thread_info()->preempt_count);
}

static inline void preempt_count_set(u64 pc)
--
2.25.1

2022-09-05 16:24:50

by Deyan Wang

Subject: Re: [PATCH 1/1] arm64: preempt: Add NEED_RESCHED to the preempt_count()

I know it is wrong. I just want to say I think preempt_count() need include NEED_RESCHED

2022-09-06 12:58:37

by Will Deacon

Subject: Re: [PATCH 1/1] arm64: preempt: Add NEED_RESCHED to the preempt_count()

On Mon, Sep 05, 2022 at 11:50:13PM +0800, [email protected] wrote:
> I know it is wrong. I just want to say I think preempt_count() need include NEED_RESCHED

Won't that break everybody expecting a count? I'm not sure what you're
asking from us here.

Will