2022-09-06 09:45:31

by Xiu Jianfeng

Subject: [PATCH -next] secretmem: use ATOMIC_INIT() to initialize secretmem_users

The variable secretmem_users is of atomic_t type, so initialize it
properly with ATOMIC_INIT().

Signed-off-by: Xiu Jianfeng <[email protected]>
---
mm/secretmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/secretmem.c b/mm/secretmem.c
index e3e9590c6fb3..796d3a92992a 100644
--- a/mm/secretmem.c
+++ b/mm/secretmem.c
@@ -40,7 +40,7 @@ module_param_named(enable, secretmem_enable, bool, 0400);
MODULE_PARM_DESC(secretmem_enable,
"Enable secretmem and memfd_secret(2) system call");

-static atomic_t secretmem_users;
+static atomic_t secretmem_users = ATOMIC_INIT(0);

bool secretmem_active(void)
{
--
2.17.1

2022-09-07 06:30:36

by Andrew Morton

Subject: Re: [PATCH -next] secretmem: use ATOMIC_INIT() to initialize secretmem_users

On Tue, 6 Sep 2022 17:36:20 +0800 Xiu Jianfeng <[email protected]> wrote:

> The variable secretmem_users is of atomic_t type, so initialize it
> properly with ATOMIC_INIT().
>

True, but there are many many cases where we initialize an atomic_t to
the all-zeroes pattern. So many that this should be considered
acceptable practice.