2022-09-08 02:24:24

by Yang Jihong

Subject: [PATCH] perf lock: Remove redundant word 'contention' in help message

Before:
# perf lock -h

Usage: perf lock [<options>] {record|report|script|info|contention|contention}

-D, --dump-raw-trace dump raw trace in ASCII
-f, --force don't complain, do it
-i, --input <file> input file name
-v, --verbose be more verbose (show symbol address, etc)
--kallsyms <file>
kallsyms pathname
--vmlinux <file> vmlinux pathname

After:
# perf lock -h

Usage: perf lock [<options>] {record|report|script|info|contention}

-D, --dump-raw-trace dump raw trace in ASCII
-f, --force don't complain, do it
-i, --input <file> input file name
-v, --verbose be more verbose (show symbol address, etc)
--kallsyms <file>
kallsyms pathname
--vmlinux <file> vmlinux pathname

Fixes: 528b9cab3b81 ("perf lock: Add 'contention' subcommand")
Signed-off-by: Yang Jihong <[email protected]>
---
tools/perf/builtin-lock.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tools/perf/builtin-lock.c b/tools/perf/builtin-lock.c
index dd11d3471baf..ea40ae52cd2c 100644
--- a/tools/perf/builtin-lock.c
+++ b/tools/perf/builtin-lock.c
@@ -1874,8 +1874,7 @@ int cmd_lock(int argc, const char **argv)
NULL
};
const char *const lock_subcommands[] = { "record", "report", "script",
- "info", "contention",
- "contention", NULL };
+ "info", "contention", NULL };
const char *lock_usage[] = {
NULL,
NULL
--
2.30.GIT

2022-09-08 07:19:28

by Namhyung Kim

Subject: Re: [PATCH] perf lock: Remove redundant word 'contention' in help message

Hello,

On Wed, Sep 7, 2022 at 6:52 PM Yang Jihong <[email protected]> wrote:
>
> Before:
> # perf lock -h
>
> Usage: perf lock [<options>] {record|report|script|info|contention|contention}
>
> -D, --dump-raw-trace dump raw trace in ASCII
> -f, --force don't complain, do it
> -i, --input <file> input file name
> -v, --verbose be more verbose (show symbol address, etc)
> --kallsyms <file>
> kallsyms pathname
> --vmlinux <file> vmlinux pathname
>
> After:
> # perf lock -h
>
> Usage: perf lock [<options>] {record|report|script|info|contention}
>
> -D, --dump-raw-trace dump raw trace in ASCII
> -f, --force don't complain, do it
> -i, --input <file> input file name
> -v, --verbose be more verbose (show symbol address, etc)
> --kallsyms <file>
> kallsyms pathname
> --vmlinux <file> vmlinux pathname
>
> Fixes: 528b9cab3b81 ("perf lock: Add 'contention' subcommand")
> Signed-off-by: Yang Jihong <[email protected]>

Acked-by: Namhyung Kim <[email protected]>

Thanks for the fix!

Namhyung


> ---
> tools/perf/builtin-lock.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/tools/perf/builtin-lock.c b/tools/perf/builtin-lock.c
> index dd11d3471baf..ea40ae52cd2c 100644
> --- a/tools/perf/builtin-lock.c
> +++ b/tools/perf/builtin-lock.c
> @@ -1874,8 +1874,7 @@ int cmd_lock(int argc, const char **argv)
> NULL
> };
> const char *const lock_subcommands[] = { "record", "report", "script",
> - "info", "contention",
> - "contention", NULL };
> + "info", "contention", NULL };
> const char *lock_usage[] = {
> NULL,
> NULL
> --
> 2.30.GIT
>

2022-09-08 19:38:07

by Arnaldo Carvalho de Melo

Subject: Re: [PATCH] perf lock: Remove redundant word 'contention' in help message

Em Wed, Sep 07, 2022 at 11:59:27PM -0700, Namhyung Kim escreveu:
> On Wed, Sep 7, 2022 at 6:52 PM Yang Jihong <[email protected]> wrote:
> > Fixes: 528b9cab3b81 ("perf lock: Add 'contention' subcommand")
> > Signed-off-by: Yang Jihong <[email protected]>

> Acked-by: Namhyung Kim <[email protected]>

> Thanks for the fix!

Thanks, applied.

- Arnaldo