2022-09-08 14:39:51

by Andy Shevchenko

Subject: [PATCH v1 1/1] pinctrl: cy8c95x0: Use 'default' in all switch-cases (part 2)

Move the default values to the 'default' case in the switches.

Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/pinctrl/pinctrl-cy8c95x0.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-cy8c95x0.c b/drivers/pinctrl/pinctrl-cy8c95x0.c
index 1335d07822f9..79f73d364f3f 100644
--- a/drivers/pinctrl/pinctrl-cy8c95x0.c
+++ b/drivers/pinctrl/pinctrl-cy8c95x0.c
@@ -357,9 +357,9 @@ static bool cy8c95x0_volatile_register(struct device *dev, unsigned int reg)
case CY8C95X0_DRV_PP_SLOW:
case CY8C95X0_DRV_HIZ:
return true;
+ default:
+ return false;
}
-
- return false;
}

static bool cy8c95x0_precious_register(struct device *dev, unsigned int reg)
--
2.35.1

2022-09-09 08:33:58

by Linus Walleij

Subject: Re: [PATCH v1 1/1] pinctrl: cy8c95x0: Use 'default' in all switch-cases (part 2)

On Thu, Sep 8, 2022 at 4:21 PM Andy Shevchenko
<[email protected]> wrote:

> Move the default values to the 'default' case in the switches.
>
> Signed-off-by: Andy Shevchenko <[email protected]>

Patch applied!

> case CY8C95X0_DRV_PP_SLOW:
> case CY8C95X0_DRV_HIZ:
> return true;
> + default:
> + return false;
> }
> -
> - return false;
> }

Clearly this is better style, I wonder if we could teach checkpatch to
look for this? Or cocinelle?

Yours,
Linus Walleij

2022-09-09 08:52:31

by Andy Shevchenko

Subject: Re: [PATCH v1 1/1] pinctrl: cy8c95x0: Use 'default' in all switch-cases (part 2)

On Fri, Sep 09, 2022 at 10:02:51AM +0200, Linus Walleij wrote:
> On Thu, Sep 8, 2022 at 4:21 PM Andy Shevchenko
> <[email protected]> wrote:
>
> > Move the default values to the 'default' case in the switches.

> Patch applied!

Thanks!

...

> > case CY8C95X0_DRV_PP_SLOW:
> > case CY8C95X0_DRV_HIZ:
> > return true;
> > + default:
> > + return false;
> > }
> > -
> > - return false;
>
> Clearly this is better style, I wonder if we could teach checkpatch to
> look for this? Or cocinelle?

The latter I believe. But I'm too busy and too lazy to go that road.

--
With Best Regards,
Andy Shevchenko