2022-09-12 10:48:41

by CGEL

Subject: [PATCH linux-next] speakup/utils: use "!P" instead of "P == 0"

From: Xu Panda <[email protected]>

comparing pointer to 0, use !P instead of it.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Xu Panda <[email protected]>
---
drivers/accessibility/speakup/utils.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/accessibility/speakup/utils.h b/drivers/accessibility/speakup/utils.h
index 4bf2ee8ac246..58ca9847637f 100644
--- a/drivers/accessibility/speakup/utils.h
+++ b/drivers/accessibility/speakup/utils.h
@@ -36,7 +36,7 @@ static inline void open_input(const char *dir_name, const char *name)
else
snprintf(filename, sizeof(filename), "%s", name);
infile = fopen(filename, "r");
- if (infile == 0) {
+ if (!infile) {
fprintf(stderr, "can't open %s\n", filename);
exit(1);
}
--
2.15.2

2022-09-12 11:05:20

by Samuel Thibault

Subject: Re: [PATCH linux-next] speakup/utils: use "!P" instead of "P == 0"

[email protected], le lun. 12 sept. 2022 10:21:00 +0000, a ecrit:
> From: Xu Panda <[email protected]>
>
> comparing pointer to 0, use !P instead of it.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Xu Panda <[email protected]>

Reviewed-by: Samuel Thibault <[email protected]>

> ---
> drivers/accessibility/speakup/utils.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/accessibility/speakup/utils.h b/drivers/accessibility/speakup/utils.h
> index 4bf2ee8ac246..58ca9847637f 100644
> --- a/drivers/accessibility/speakup/utils.h
> +++ b/drivers/accessibility/speakup/utils.h
> @@ -36,7 +36,7 @@ static inline void open_input(const char *dir_name, const char *name)
> else
> snprintf(filename, sizeof(filename), "%s", name);
> infile = fopen(filename, "r");
> - if (infile == 0) {
> + if (!infile) {
> fprintf(stderr, "can't open %s\n", filename);
> exit(1);
> }
> --
> 2.15.2
>