2022-09-14 08:17:29

by Yihao Han

Subject: [PATCH] drm/amd/display: fix boolconv.cocci warning

./drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c:729:63-68:
WARNING: conversion to bool not needed here

Generated by: scripts/coccinelle/misc/boolconv.cocci
Signed-off-by: Yihao Han <[email protected]>
---
drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c
index f4bc77972c4e..4edd0655965b 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c
@@ -726,7 +726,7 @@ static bool mpc32_program_shaper(
else
next_mode = LUT_RAM_A;

- mpc32_configure_shaper_lut(mpc, next_mode == LUT_RAM_A ? true:false, mpcc_id);
+ mpc32_configure_shaper_lut(mpc, next_mode == LUT_RAM_A, mpcc_id);

if (next_mode == LUT_RAM_A)
mpc32_program_shaper_luta_settings(mpc, params, mpcc_id);
--
2.17.1

2022-09-14 14:06:05

by Alex Deucher

Subject: Re: [PATCH] drm/amd/display: fix boolconv.cocci warning

Applied. Thanks!

On Wed, Sep 14, 2022 at 3:53 AM Yihao Han <[email protected]> wrote:
>
> ./drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c:729:63-68:
> WARNING: conversion to bool not needed here
>
> Generated by: scripts/coccinelle/misc/boolconv.cocci
> Signed-off-by: Yihao Han <[email protected]>
> ---
> drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c
> index f4bc77972c4e..4edd0655965b 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c
> @@ -726,7 +726,7 @@ static bool mpc32_program_shaper(
> else
> next_mode = LUT_RAM_A;
>
> - mpc32_configure_shaper_lut(mpc, next_mode == LUT_RAM_A ? true:false, mpcc_id);
> + mpc32_configure_shaper_lut(mpc, next_mode == LUT_RAM_A, mpcc_id);
>
> if (next_mode == LUT_RAM_A)
> mpc32_program_shaper_luta_settings(mpc, params, mpcc_id);
> --
> 2.17.1
>