2022-09-14 10:50:23

by Jiapeng Chong

Subject: [PATCH] video: fbdev: controlfb: Remove the unused function VAR_MATCH()

The function VAR_MATCH is defined in the controlfb.c file, but not
called elsewhere, so delete this unused function.

drivers/video/fbdev/controlfb.c:111:19: warning: unused function 'VAR_MATCH'.

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2153
Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/video/fbdev/controlfb.c | 7 -------
1 file changed, 7 deletions(-)

diff --git a/drivers/video/fbdev/controlfb.c b/drivers/video/fbdev/controlfb.c
index aba46118b208..6bbcd9fc864e 100644
--- a/drivers/video/fbdev/controlfb.c
+++ b/drivers/video/fbdev/controlfb.c
@@ -108,13 +108,6 @@ static inline int PAR_EQUAL(struct fb_par_control *x, struct fb_par_control *y)
return (!DIRTY(cmode) && !DIRTY(xres) && !DIRTY(yres)
&& !DIRTY(vxres) && !DIRTY(vyres));
}
-static inline int VAR_MATCH(struct fb_var_screeninfo *x, struct fb_var_screeninfo *y)
-{
- return (!DIRTY(bits_per_pixel) && !DIRTY(xres)
- && !DIRTY(yres) && !DIRTY(xres_virtual)
- && !DIRTY(yres_virtual)
- && !DIRTY_CMAP(red) && !DIRTY_CMAP(green) && !DIRTY_CMAP(blue));
-}

struct fb_info_control {
struct fb_info info;
--
2.20.1.7.g153144c

2022-09-25 11:55:28

by Helge Deller

Subject: Re: [PATCH] video: fbdev: controlfb: Remove the unused function VAR_MATCH()

On 9/14/22 12:22, Jiapeng Chong wrote:
> The function VAR_MATCH is defined in the controlfb.c file, but not
> called elsewhere, so delete this unused function.
>
> drivers/video/fbdev/controlfb.c:111:19: warning: unused function 'VAR_MATCH'.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2153
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>

applied.

Thanks,
Helge


> ---
> drivers/video/fbdev/controlfb.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/video/fbdev/controlfb.c b/drivers/video/fbdev/controlfb.c
> index aba46118b208..6bbcd9fc864e 100644
> --- a/drivers/video/fbdev/controlfb.c
> +++ b/drivers/video/fbdev/controlfb.c
> @@ -108,13 +108,6 @@ static inline int PAR_EQUAL(struct fb_par_control *x, struct fb_par_control *y)
> return (!DIRTY(cmode) && !DIRTY(xres) && !DIRTY(yres)
> && !DIRTY(vxres) && !DIRTY(vyres));
> }
> -static inline int VAR_MATCH(struct fb_var_screeninfo *x, struct fb_var_screeninfo *y)
> -{
> - return (!DIRTY(bits_per_pixel) && !DIRTY(xres)
> - && !DIRTY(yres) && !DIRTY(xres_virtual)
> - && !DIRTY(yres_virtual)
> - && !DIRTY_CMAP(red) && !DIRTY_CMAP(green) && !DIRTY_CMAP(blue));
> -}
>
> struct fb_info_control {
> struct fb_info info;