2022-09-17 23:48:46

by Randy Dunlap

Subject: [PATCH] MIPS: lantiq: export clk_get_io() for lantiq_wdt.ko

The lantiq WDT driver uses clk_get_io(), which is not exported,
so export it to fix a build error:

ERROR: modpost: "clk_get_io" [drivers/watchdog/lantiq_wdt.ko] undefined!

Fixes: 287e3f3f4e68 ("MIPS: lantiq: implement support for clkdev api")
Signed-off-by: Randy Dunlap <[email protected]>
Reported-by: kernel test robot <[email protected]>
Cc: Thomas Bogendoerfer <[email protected]>
Cc: John Crispin <[email protected]>
Cc: [email protected]
---
arch/mips/lantiq/clk.c | 1 +
1 file changed, 1 insertion(+)

--- a/arch/mips/lantiq/clk.c
+++ b/arch/mips/lantiq/clk.c
@@ -50,6 +50,7 @@ struct clk *clk_get_io(void)
{
return &cpu_clk_generic[2];
}
+EXPORT_SYMBOL_GPL(clk_get_io);

struct clk *clk_get_ppe(void)
{

2022-09-19 15:14:07

by Thomas Bogendoerfer

Subject: Re: [PATCH] MIPS: lantiq: export clk_get_io() for lantiq_wdt.ko

On Sat, Sep 17, 2022 at 04:25:40PM -0700, Randy Dunlap wrote:
> The lantiq WDT driver uses clk_get_io(), which is not exported,
> so export it to fix a build error:
>
> ERROR: modpost: "clk_get_io" [drivers/watchdog/lantiq_wdt.ko] undefined!
>
> Fixes: 287e3f3f4e68 ("MIPS: lantiq: implement support for clkdev api")
> Signed-off-by: Randy Dunlap <[email protected]>
> Reported-by: kernel test robot <[email protected]>
> Cc: Thomas Bogendoerfer <[email protected]>
> Cc: John Crispin <[email protected]>
> Cc: [email protected]
> ---
> arch/mips/lantiq/clk.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- a/arch/mips/lantiq/clk.c
> +++ b/arch/mips/lantiq/clk.c
> @@ -50,6 +50,7 @@ struct clk *clk_get_io(void)
> {
> return &cpu_clk_generic[2];
> }
> +EXPORT_SYMBOL_GPL(clk_get_io);
>
> struct clk *clk_get_ppe(void)
> {

applied to mips-fixes.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]