2022-09-20 07:14:52

by CGEL

Subject: [PATCH linux-next] drm/amd/pm: Remove the unneeded result variable

From: ye xingchen <[email protected]>

Return the value append_vbios_pptable() directly instead of storing it in
another redundant variable.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: ye xingchen <[email protected]>
---
.../gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c
index 1e79baab753e..bd54fbd393b9 100644
--- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c
+++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c
@@ -195,7 +195,6 @@ static int init_powerplay_table_information(
struct phm_ppt_v3_information *pptable_information =
(struct phm_ppt_v3_information *)hwmgr->pptable;
uint32_t disable_power_control = 0;
- int result;

hwmgr->thermal_controller.ucType = powerplay_table->ucThermalControllerType;
pptable_information->uc_thermal_controller_type = powerplay_table->ucThermalControllerType;
@@ -257,9 +256,7 @@ static int init_powerplay_table_information(
if (pptable_information->smc_pptable == NULL)
return -ENOMEM;

- result = append_vbios_pptable(hwmgr, (pptable_information->smc_pptable));
-
- return result;
+ return append_vbios_pptable(hwmgr, (pptable_information->smc_pptable));
}

static int vega12_pp_tables_initialize(struct pp_hwmgr *hwmgr)
--
2.25.1

2022-09-20 16:27:35

by Alex Deucher

Subject: Re: [PATCH linux-next] drm/amd/pm: Remove the unneeded result variable

Applied. Thanks.

On Tue, Sep 20, 2022 at 2:35 AM <[email protected]> wrote:
>
> From: ye xingchen <[email protected]>
>
> Return the value append_vbios_pptable() directly instead of storing it in
> another redundant variable.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: ye xingchen <[email protected]>
> ---
> .../gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c
> index 1e79baab753e..bd54fbd393b9 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c
> +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c
> @@ -195,7 +195,6 @@ static int init_powerplay_table_information(
> struct phm_ppt_v3_information *pptable_information =
> (struct phm_ppt_v3_information *)hwmgr->pptable;
> uint32_t disable_power_control = 0;
> - int result;
>
> hwmgr->thermal_controller.ucType = powerplay_table->ucThermalControllerType;
> pptable_information->uc_thermal_controller_type = powerplay_table->ucThermalControllerType;
> @@ -257,9 +256,7 @@ static int init_powerplay_table_information(
> if (pptable_information->smc_pptable == NULL)
> return -ENOMEM;
>
> - result = append_vbios_pptable(hwmgr, (pptable_information->smc_pptable));
> -
> - return result;
> + return append_vbios_pptable(hwmgr, (pptable_information->smc_pptable));
> }
>
> static int vega12_pp_tables_initialize(struct pp_hwmgr *hwmgr)
> --
> 2.25.1