2022-09-20 07:27:18

by CGEL

Subject: [PATCH linux-next] mmc: rtsx_usb_sdmmc: Remove the unneeded result variable

From: ye xingchen <[email protected]>

Return the value rtsx_usb_send_cmd() directly instead of storing it in
another redundant variable.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: ye xingchen <[email protected]>
---
drivers/mmc/host/rtsx_usb_sdmmc.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/mmc/host/rtsx_usb_sdmmc.c b/drivers/mmc/host/rtsx_usb_sdmmc.c
index 5fe4528e296e..5798aee06653 100644
--- a/drivers/mmc/host/rtsx_usb_sdmmc.c
+++ b/drivers/mmc/host/rtsx_usb_sdmmc.c
@@ -1042,7 +1042,6 @@ static int sd_set_timing(struct rtsx_usb_sdmmc *host,
unsigned char timing, bool *ddr_mode)
{
struct rtsx_ucr *ucr = host->ucr;
- int err;

*ddr_mode = false;

@@ -1097,9 +1096,7 @@ static int sd_set_timing(struct rtsx_usb_sdmmc *host,
break;
}

- err = rtsx_usb_send_cmd(ucr, MODE_C, 100);
-
- return err;
+ return rtsx_usb_send_cmd(ucr, MODE_C, 100);
}

static void sdmmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
--
2.25.1

2022-09-21 13:06:27

by Ulf Hansson

Subject: Re: [PATCH linux-next] mmc: rtsx_usb_sdmmc: Remove the unneeded result variable

On Tue, 20 Sept 2022 at 08:46, <[email protected]> wrote:
>
> From: ye xingchen <[email protected]>
>
> Return the value rtsx_usb_send_cmd() directly instead of storing it in
> another redundant variable.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: ye xingchen <[email protected]>

Applied for next, thanks!

Kind regards
Uffe


> ---
> drivers/mmc/host/rtsx_usb_sdmmc.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/rtsx_usb_sdmmc.c b/drivers/mmc/host/rtsx_usb_sdmmc.c
> index 5fe4528e296e..5798aee06653 100644
> --- a/drivers/mmc/host/rtsx_usb_sdmmc.c
> +++ b/drivers/mmc/host/rtsx_usb_sdmmc.c
> @@ -1042,7 +1042,6 @@ static int sd_set_timing(struct rtsx_usb_sdmmc *host,
> unsigned char timing, bool *ddr_mode)
> {
> struct rtsx_ucr *ucr = host->ucr;
> - int err;
>
> *ddr_mode = false;
>
> @@ -1097,9 +1096,7 @@ static int sd_set_timing(struct rtsx_usb_sdmmc *host,
> break;
> }
>
> - err = rtsx_usb_send_cmd(ucr, MODE_C, 100);
> -
> - return err;
> + return rtsx_usb_send_cmd(ucr, MODE_C, 100);
> }
>
> static void sdmmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
> --
> 2.25.1