2022-08-01 03:07:24

by Tudor Ambarus

Subject: [PATCH] mtd: rawnand: intel: Remove macro that is already defined in the core

NAND_DATA_IFACE_CHECK_ONLY is already defined in
include/linux/mtd/rawnand.h. The intel driver includes
<linux/mtd/rawnand.h>, so remove the duplicate definition from the intel
driver.

Signed-off-by: Tudor Ambarus <[email protected]>
---
drivers/mtd/nand/raw/intel-nand-controller.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/mtd/nand/raw/intel-nand-controller.c b/drivers/mtd/nand/raw/intel-nand-controller.c
index 7c1c80dae826..fbf6731420d6 100644
--- a/drivers/mtd/nand/raw/intel-nand-controller.c
+++ b/drivers/mtd/nand/raw/intel-nand-controller.c
@@ -99,8 +99,6 @@

#define HSNAND_ECC_OFFSET 0x008

-#define NAND_DATA_IFACE_CHECK_ONLY -1
-
#define MAX_CS 2

#define USEC_PER_SEC 1000000L
--
2.25.1

2022-09-20 08:24:46

by Miquel Raynal

Subject: Re: [PATCH] mtd: rawnand: intel: Remove macro that is already defined in the core

Hi Tudor,

[email protected] wrote on Mon, 1 Aug 2022 05:57:40 +0300:

> NAND_DATA_IFACE_CHECK_ONLY is already defined in
> include/linux/mtd/rawnand.h. The intel driver includes
> <linux/mtd/rawnand.h>, so remove the duplicate definition from the intel
> driver.
>
> Signed-off-by: Tudor Ambarus <[email protected]>
> ---
> drivers/mtd/nand/raw/intel-nand-controller.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/intel-nand-controller.c b/drivers/mtd/nand/raw/intel-nand-controller.c
> index 7c1c80dae826..fbf6731420d6 100644
> --- a/drivers/mtd/nand/raw/intel-nand-controller.c
> +++ b/drivers/mtd/nand/raw/intel-nand-controller.c
> @@ -99,8 +99,6 @@
>
> #define HSNAND_ECC_OFFSET 0x008
>
> -#define NAND_DATA_IFACE_CHECK_ONLY -1
> -
> #define MAX_CS 2
>
> #define USEC_PER_SEC 1000000L

Actually I already received a series which contains a patch doing
exactly that. But thanks anyway :-)

Cheers,
Miquèl