2022-07-27 13:45:33

by Pali Rohár

Subject: [PATCH] ARM: dts: turris-omnia: Add ethernet aliases

This allows bootloader to correctly pass MAC addresses used by bootloader
to individual interfaces into kernel device tree.

Signed-off-by: Pali Rohár <[email protected]>
---
arch/arm/boot/dts/armada-385-turris-omnia.dts | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
index f4eb6898aa6b..d2afa466e29a 100644
--- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
+++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
@@ -23,6 +23,12 @@
stdout-path = &uart0;
};

+ aliases {
+ ethernet0 = &eth0;
+ ethernet1 = &eth1;
+ ethernet2 = &eth2;
+ };
+
memory {
device_type = "memory";
reg = <0x00000000 0x40000000>; /* 1024 MB */
--
2.20.1

2022-07-27 13:46:52

by Pali Rohár

Subject: Re: [PATCH] ARM: dts: turris-omnia: Add ethernet aliases

On Wednesday 27 July 2022 15:09:26 Pali Rohár wrote:
> This allows bootloader to correctly pass MAC addresses used by bootloader
> to individual interfaces into kernel device tree.
>
> Signed-off-by: Pali Rohár <[email protected]>
> ---

Maybe this should have Fixes line?

Fixes: 26ca8b52d6e1 ("ARM: dts: add support for Turris Omnia")

> arch/arm/boot/dts/armada-385-turris-omnia.dts | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> index f4eb6898aa6b..d2afa466e29a 100644
> --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
> +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> @@ -23,6 +23,12 @@
> stdout-path = &uart0;
> };
>
> + aliases {
> + ethernet0 = &eth0;
> + ethernet1 = &eth1;
> + ethernet2 = &eth2;
> + };
> +
> memory {
> device_type = "memory";
> reg = <0x00000000 0x40000000>; /* 1024 MB */
> --
> 2.20.1
>

2022-08-09 21:16:33

by Andrew Lunn

Subject: Re: [PATCH] ARM: dts: turris-omnia: Add ethernet aliases

On Wed, Jul 27, 2022 at 03:15:04PM +0200, Pali Roh?r wrote:
> On Wednesday 27 July 2022 15:09:26 Pali Roh?r wrote:
> > This allows bootloader to correctly pass MAC addresses used by bootloader
> > to individual interfaces into kernel device tree.
> >
> > Signed-off-by: Pali Roh?r <[email protected]>
> > ---
>
> Maybe this should have Fixes line?
>
> Fixes: 26ca8b52d6e1 ("ARM: dts: add support for Turris Omnia")

Is it broken with older kernels? That is a big part of Fixes: to
indicate it needs back porting. Is this a new u-boot feature?

Andrew

2022-08-09 21:17:08

by Pali Rohár

Subject: Re: [PATCH] ARM: dts: turris-omnia: Add ethernet aliases

On Tuesday 09 August 2022 22:28:51 Andrew Lunn wrote:
> On Wed, Jul 27, 2022 at 03:15:04PM +0200, Pali Rohár wrote:
> > On Wednesday 27 July 2022 15:09:26 Pali Rohár wrote:
> > > This allows bootloader to correctly pass MAC addresses used by bootloader
> > > to individual interfaces into kernel device tree.
> > >
> > > Signed-off-by: Pali Rohár <[email protected]>
> > > ---
> >
> > Maybe this should have Fixes line?
> >
> > Fixes: 26ca8b52d6e1 ("ARM: dts: add support for Turris Omnia")
>
> Is it broken with older kernels? That is a big part of Fixes: to
> indicate it needs back porting. Is this a new u-boot feature?
>
> Andrew

This is old u-boot feature. I was investigating why u-boot is not able
to correctly modify loaded omnia dtb file when booting linux kernel and
I found out that it is because it cannot due to missing ethernet
aliases.

Also there is a new u-boot feature for omnia to correctly put
phy-reset-gpios property into eth 2 node based on board hw revision. So
this is another purpose for which we should have those aliases, to allow
kernel to correctly reset wan (eth 2) PHY.

I would suggest this change for backporting into stable.

2022-09-24 12:25:37

by Pali Rohár

Subject: Re: [PATCH] ARM: dts: turris-omnia: Add ethernet aliases

PING?

On Wednesday 27 July 2022 15:09:26 Pali Rohár wrote:
> This allows bootloader to correctly pass MAC addresses used by bootloader
> to individual interfaces into kernel device tree.
>
> Signed-off-by: Pali Rohár <[email protected]>
> ---
> arch/arm/boot/dts/armada-385-turris-omnia.dts | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> index f4eb6898aa6b..d2afa466e29a 100644
> --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
> +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> @@ -23,6 +23,12 @@
> stdout-path = &uart0;
> };
>
> + aliases {
> + ethernet0 = &eth0;
> + ethernet1 = &eth1;
> + ethernet2 = &eth2;
> + };
> +
> memory {
> device_type = "memory";
> reg = <0x00000000 0x40000000>; /* 1024 MB */
> --
> 2.20.1
>

2022-10-09 11:52:29

by Pali Rohár

Subject: Re: [PATCH] ARM: dts: turris-omnia: Add ethernet aliases

Gregory: PING?

On Saturday 24 September 2022 14:13:02 Pali Rohár wrote:
> PING?
>
> On Wednesday 27 July 2022 15:09:26 Pali Rohár wrote:
> > This allows bootloader to correctly pass MAC addresses used by bootloader
> > to individual interfaces into kernel device tree.
> >
> > Signed-off-by: Pali Rohár <[email protected]>
> > ---
> > arch/arm/boot/dts/armada-385-turris-omnia.dts | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> > index f4eb6898aa6b..d2afa466e29a 100644
> > --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
> > +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> > @@ -23,6 +23,12 @@
> > stdout-path = &uart0;
> > };
> >
> > + aliases {
> > + ethernet0 = &eth0;
> > + ethernet1 = &eth1;
> > + ethernet2 = &eth2;
> > + };
> > +
> > memory {
> > device_type = "memory";
> > reg = <0x00000000 0x40000000>; /* 1024 MB */
> > --
> > 2.20.1
> >

2022-11-01 23:55:22

by Pali Rohár

Subject: Re: [PATCH] ARM: dts: turris-omnia: Add ethernet aliases

PING?

On Sunday 09 October 2022 13:46:59 Pali Rohár wrote:
> Gregory: PING?
>
> On Saturday 24 September 2022 14:13:02 Pali Rohár wrote:
> > PING?
> >
> > On Wednesday 27 July 2022 15:09:26 Pali Rohár wrote:
> > > This allows bootloader to correctly pass MAC addresses used by bootloader
> > > to individual interfaces into kernel device tree.
> > >
> > > Signed-off-by: Pali Rohár <[email protected]>
> > > ---
> > > arch/arm/boot/dts/armada-385-turris-omnia.dts | 6 ++++++
> > > 1 file changed, 6 insertions(+)
> > >
> > > diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> > > index f4eb6898aa6b..d2afa466e29a 100644
> > > --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
> > > +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> > > @@ -23,6 +23,12 @@
> > > stdout-path = &uart0;
> > > };
> > >
> > > + aliases {
> > > + ethernet0 = &eth0;
> > > + ethernet1 = &eth1;
> > > + ethernet2 = &eth2;
> > > + };
> > > +
> > > memory {
> > > device_type = "memory";
> > > reg = <0x00000000 0x40000000>; /* 1024 MB */
> > > --
> > > 2.20.1
> > >

2022-11-28 00:11:26

by Gregory CLEMENT

Subject: Re: [PATCH] ARM: dts: turris-omnia: Add ethernet aliases

Pali Rohár <[email protected]> writes:

> This allows bootloader to correctly pass MAC addresses used by bootloader
> to individual interfaces into kernel device tree.
>
> Signed-off-by: Pali Rohár <[email protected]>

Applied on mvebu/dt

Thanks,

Gregory
> ---
> arch/arm/boot/dts/armada-385-turris-omnia.dts | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> index f4eb6898aa6b..d2afa466e29a 100644
> --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
> +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> @@ -23,6 +23,12 @@
> stdout-path = &uart0;
> };
>
> + aliases {
> + ethernet0 = &eth0;
> + ethernet1 = &eth1;
> + ethernet2 = &eth2;
> + };
> +
> memory {
> device_type = "memory";
> reg = <0x00000000 0x40000000>; /* 1024 MB */
> --
> 2.20.1
>

--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com