2022-09-27 02:21:34

by Jason Yan

Subject: [PATCH v3 8/8] scsi: libsas: use sas_phy_match_port_addr() instead of open coded

The sas address comparation of asd_sas_port and expander phy is open
coded. Now we can replace it with sas_phy_match_port_addr().

Signed-off-by: Jason Yan <[email protected]>
---
drivers/scsi/libsas/sas_expander.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/scsi/libsas/sas_expander.c b/drivers/scsi/libsas/sas_expander.c
index f268291b7584..eabc56966f36 100644
--- a/drivers/scsi/libsas/sas_expander.c
+++ b/drivers/scsi/libsas/sas_expander.c
@@ -1005,8 +1005,7 @@ static int sas_ex_discover_dev(struct domain_device *dev, int phy_id)
}

/* Parent and domain coherency */
- if (!dev->parent && (SAS_ADDR(ex_phy->attached_sas_addr) ==
- SAS_ADDR(dev->port->sas_addr))) {
+ if (!dev->parent && sas_phy_match_port_addr(dev->port, ex_phy)) {
sas_add_parent_port(dev, phy_id);
return 0;
}
--
2.31.1

2022-09-27 03:26:14

by Damien Le Moal

Subject: Re: [PATCH v3 8/8] scsi: libsas: use sas_phy_match_port_addr() instead of open coded

On 9/27/22 11:29, Jason Yan wrote:
> The sas address comparation of asd_sas_port and expander phy is open
> coded. Now we can replace it with sas_phy_match_port_addr().

Comparison typo again.

>
> Signed-off-by: Jason Yan <[email protected]>

With that fixed,

Reviewed-by: Damien Le Moal <[email protected]>

> ---
> drivers/scsi/libsas/sas_expander.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/libsas/sas_expander.c b/drivers/scsi/libsas/sas_expander.c
> index f268291b7584..eabc56966f36 100644
> --- a/drivers/scsi/libsas/sas_expander.c
> +++ b/drivers/scsi/libsas/sas_expander.c
> @@ -1005,8 +1005,7 @@ static int sas_ex_discover_dev(struct domain_device *dev, int phy_id)
> }
>
> /* Parent and domain coherency */
> - if (!dev->parent && (SAS_ADDR(ex_phy->attached_sas_addr) ==
> - SAS_ADDR(dev->port->sas_addr))) {
> + if (!dev->parent && sas_phy_match_port_addr(dev->port, ex_phy)) {
> sas_add_parent_port(dev, phy_id);
> return 0;
> }

--
Damien Le Moal
Western Digital Research