2022-09-28 12:45:09

by Jiachen Zhang

Subject: [PATCH] fuse: always revalidate rename target dentry

The previous commit df8629af2934 ("fuse: always revalidate if exclusive
create") ensures that the dentries are revalidated on O_EXCL creates. This
commit complements it by also performing revalidation for rename target
dentries. Otherwise, a rename target file that only exists in kernel dentry
cache but not in the filesystem may result in an EEXIST.

Signed-off-by: Jiachen Zhang <[email protected]>
Signed-off-by: Zhang Tianci <[email protected]>
---
fs/fuse/dir.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c
index b585b04e815e..a453fc57ce4f 100644
--- a/fs/fuse/dir.c
+++ b/fs/fuse/dir.c
@@ -214,7 +214,7 @@ static int fuse_dentry_revalidate(struct dentry *entry, unsigned int flags)
if (inode && fuse_is_bad(inode))
goto invalid;
else if (time_before64(fuse_dentry_time(entry), get_jiffies_64()) ||
- (flags & (LOOKUP_EXCL | LOOKUP_REVAL))) {
+ (flags & (LOOKUP_EXCL | LOOKUP_REVAL | LOOKUP_RENAME_TARGET))) {
struct fuse_entry_out outarg;
FUSE_ARGS(args);
struct fuse_forget_link *forget;
--
2.20.1

2022-10-12 14:05:35

by Miklos Szeredi

Subject: Re: [PATCH] fuse: always revalidate rename target dentry

On Wed, 28 Sept 2022 at 14:20, Jiachen Zhang
<[email protected]> wrote:
>
> The previous commit df8629af2934 ("fuse: always revalidate if exclusive
> create") ensures that the dentries are revalidated on O_EXCL creates. This
> commit complements it by also performing revalidation for rename target
> dentries. Otherwise, a rename target file that only exists in kernel dentry
> cache but not in the filesystem may result in an EEXIST.

"...will result in EEXIST if RENAME_NOREPLACE flag is used."

Applied with the above change.

Thanks,
Miklos