2022-10-05 08:11:17

by Chin-Ting Kuo

Subject: [PATCH] spi: aspeed: Fix typo in mode_bits field for AST2600 platform

Both quad SPI TX and RX modes can be supported on AST2600.
Correct typo in mode_bits field in both ast2600_fmc_data
ast2600_spi_data structs.

Signed-off-by: Chin-Ting Kuo <[email protected]>
---
drivers/spi/spi-aspeed-smc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/spi-aspeed-smc.c b/drivers/spi/spi-aspeed-smc.c
index a334e89add86..33cefcf18392 100644
--- a/drivers/spi/spi-aspeed-smc.c
+++ b/drivers/spi/spi-aspeed-smc.c
@@ -1163,7 +1163,7 @@ static const struct aspeed_spi_data ast2500_spi_data = {
static const struct aspeed_spi_data ast2600_fmc_data = {
.max_cs = 3,
.hastype = false,
- .mode_bits = SPI_RX_QUAD | SPI_RX_QUAD,
+ .mode_bits = SPI_RX_QUAD | SPI_TX_QUAD,
.we0 = 16,
.ctl0 = CE0_CTRL_REG,
.timing = CE0_TIMING_COMPENSATION_REG,
@@ -1178,7 +1178,7 @@ static const struct aspeed_spi_data ast2600_fmc_data = {
static const struct aspeed_spi_data ast2600_spi_data = {
.max_cs = 2,
.hastype = false,
- .mode_bits = SPI_RX_QUAD | SPI_RX_QUAD,
+ .mode_bits = SPI_RX_QUAD | SPI_TX_QUAD,
.we0 = 16,
.ctl0 = CE0_CTRL_REG,
.timing = CE0_TIMING_COMPENSATION_REG,
--
2.25.1

2022-10-05 09:04:01

by Chin-Ting Kuo

Subject: RE: [PATCH] spi: aspeed: Fix typo in mode_bits field for AST2600 platform

Hi All,

> -----Original Message-----
> From: Chin-Ting Kuo <[email protected]>
> Sent: Wednesday, October 5, 2022 4:01 PM
> Subject: [PATCH] spi: aspeed: Fix typo in mode_bits field for AST2600 platform
>
> Both quad SPI TX and RX modes can be supported on AST2600.
> Correct typo in mode_bits field in both ast2600_fmc_data ast2600_spi_data
> structs.

A missing "and" in "both ast2600_fmc_data ast2600_spi_data structs" in the commit message.
It will be updated in the next version later.


Chin-Ting

>
> Signed-off-by: Chin-Ting Kuo <[email protected]>
> ---
> drivers/spi/spi-aspeed-smc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/spi/spi-aspeed-smc.c b/drivers/spi/spi-aspeed-smc.c index
> a334e89add86..33cefcf18392 100644
> --- a/drivers/spi/spi-aspeed-smc.c
> +++ b/drivers/spi/spi-aspeed-smc.c
> @@ -1163,7 +1163,7 @@ static const struct aspeed_spi_data
> ast2500_spi_data = { static const struct aspeed_spi_data ast2600_fmc_data
> = {
> .max_cs = 3,
> .hastype = false,
> - .mode_bits = SPI_RX_QUAD | SPI_RX_QUAD,
> + .mode_bits = SPI_RX_QUAD | SPI_TX_QUAD,
> .we0 = 16,
> .ctl0 = CE0_CTRL_REG,
> .timing = CE0_TIMING_COMPENSATION_REG,
> @@ -1178,7 +1178,7 @@ static const struct aspeed_spi_data
> ast2600_fmc_data = { static const struct aspeed_spi_data ast2600_spi_data
> = {
> .max_cs = 2,
> .hastype = false,
> - .mode_bits = SPI_RX_QUAD | SPI_RX_QUAD,
> + .mode_bits = SPI_RX_QUAD | SPI_TX_QUAD,
> .we0 = 16,
> .ctl0 = CE0_CTRL_REG,
> .timing = CE0_TIMING_COMPENSATION_REG,
> --
> 2.25.1